You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/05/06 12:09:42 UTC

[GitHub] [spark] pan3793 commented on a diff in pull request #41073: [SPARK-43394][BUILD] Upgrade maven to 3.8.8

pan3793 commented on code in PR #41073:
URL: https://github.com/apache/spark/pull/41073#discussion_r1186688234


##########
docs/building-spark.md:
##########
@@ -27,7 +27,7 @@ license: |
 ## Apache Maven
 
 The Maven-based build is the build of reference for Apache Spark.
-Building Spark using Maven requires Maven 3.8.7 and Java 8.
+Building Spark using Maven requires Maven 3.8.8 and Java 8.

Review Comment:
   Based on the comments in https://github.com/apache/spark/pull/22781, I think we should change it to
   
   ```
   Building Spark using Maven requires Maven 3.8.8 and Java 8/11/17.
   ```
   
   because only the above versions were tested



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org