[GitHub] [hbase] Apache9 commented on a diff in pull request #5306: HBASE-27657: Connection and Request Attributes

["Apache9 (via GitHub)" <gi...@apache.org>]

Apache9 commented on code in PR #5306:
URL: https://github.com/apache/hbase/pull/5306#discussion_r1239225855


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcControllerImpl.java:
##########
@@ -166,6 +167,11 @@ public boolean hasCallTimeout() {
     return callTimeout != null;
   }
 
+  @Override
+  public Map<String, byte[]> getAttributes() {
+    return null;

Review Comment:
   This is not done yet?



##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:
##########
@@ -216,21 +217,53 @@ public static Connection createConnection(Configuration conf, User user) throws
    */
   public static Connection createConnection(Configuration conf, ExecutorService pool,
     final User user) throws IOException {
+    return createConnection(conf, pool, user, null);

Review Comment:
   Better just use Collections.emptyMap here, so we do not need a null check in later code, usually.



##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java:
##########
@@ -17,6 +17,8 @@
  */
 package org.apache.hadoop.hbase.ipc;
 
+import static org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos.*;

Review Comment:
   Avoid star imports



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org