You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2017/12/04 22:38:28 UTC

[whimsy] branch master updated: convert unicode space characters (excluding CRLF) to an ASCII space

This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 6ea5ad9  convert unicode space characters (excluding CRLF) to an ASCII space
6ea5ad9 is described below

commit 6ea5ad938e2f96ff1bbfaec339a05179b29935e3
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Mon Dec 4 17:36:35 2017 -0500

    convert unicode space characters (excluding CRLF) to an ASCII space
---
 www/board/agenda/views/actions/post.json.rb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/board/agenda/views/actions/post.json.rb b/www/board/agenda/views/actions/post.json.rb
index 9008679..c7a3a46 100644
--- a/www/board/agenda/views/actions/post.json.rb
+++ b/www/board/agenda/views/actions/post.json.rb
@@ -15,6 +15,9 @@ Agenda.update(@agenda, @message) do |agenda|
   # remove trailing whitespace
   @report.sub! /\s*\Z/, ''
 
+  # convert unicode space characters (excluding CRLF) to an ASCII space
+  @report.gsub!(/[[:space:]]/) {|c| "\r\n".include?(c) ? c : ' '}
+
   if @attach == '7?'
     # new special order
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].

Re: [whimsy] branch master updated: convert unicode space characters (excluding CRLF) to an ASCII space

Posted by sebb <se...@gmail.com>.
On 4 December 2017 at 22:38,  <ru...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> rubys pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 6ea5ad9  convert unicode space characters (excluding CRLF) to an ASCII space
> 6ea5ad9 is described below
>
> commit 6ea5ad938e2f96ff1bbfaec339a05179b29935e3
> Author: Sam Ruby <ru...@intertwingly.net>
> AuthorDate: Mon Dec 4 17:36:35 2017 -0500
>
>     convert unicode space characters (excluding CRLF) to an ASCII space
> ---
>  www/board/agenda/views/actions/post.json.rb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/www/board/agenda/views/actions/post.json.rb b/www/board/agenda/views/actions/post.json.rb
> index 9008679..c7a3a46 100644
> --- a/www/board/agenda/views/actions/post.json.rb
> +++ b/www/board/agenda/views/actions/post.json.rb
> @@ -15,6 +15,9 @@ Agenda.update(@agenda, @message) do |agenda|
>    # remove trailing whitespace
>    @report.sub! /\s*\Z/, ''
>
> +  # convert unicode space characters (excluding CRLF) to an ASCII space
> +  @report.gsub!(/[[:space:]]/) {|c| "\r\n".include?(c) ? c : ' '}
> +

AFAICT [[:blank:]] matches spaces but not CRLF:

"\u00A0\u202f\u2007 \t".match(/\A[[:blank:]]+\z/) => matches

"\n".match(/\A[[:blank:]]+\z/)  => nil


>    if @attach == '7?'
>      # new special order
>
>
> --
> To stop receiving notification emails like this one, please contact
> ['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].