[GitHub] [druid] TSFenwick commented on a diff in pull request #13670: msq path to emit unparseable exceptions

[GitBox <gi...@apache.org>]

TSFenwick commented on code in PR #13670:
URL: https://github.com/apache/druid/pull/13670#discussion_r1072726631


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/MSQWarningReportLimiterPublisher.java:
##########
@@ -108,6 +115,12 @@ public void publishException(int stageNumber, Throwable e)
         return;
       }
     }
+    if (CannotParseExternalDataFault.CODE.equals(errorCode)) {

Review Comment:
   `:MSQErrorReport msqFault = MSQErrorReport.fromException(workerId, host, stageNumber, e);`
   will definitely avoid repeating this call



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org