You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/30 00:42:07 UTC
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Anonymitaet commented on code in PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#discussion_r910512516
##########
conf/bookkeeper.conf:
##########
@@ -631,10 +631,10 @@ diskCheckInterval=10000
## Metadata Service settings
#############################################################################
-# metadata service uri that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location
+# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
Review Comment:
```suggestion
# Metadata service URI that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
```
Capitalize proper nouns correctly. https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.je5thtkj42cb
```suggestion
# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
```
##########
site2/docs/reference-configuration.md:
##########
@@ -72,7 +72,8 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|flushInterval|How long the interval to flush ledger index pages to disk, in milliseconds. Flushing index files will introduce much random disk I/O. If separating journal dir and ledger dirs each on different devices, flushing would not affect performance. But if putting journal dir and ledger dirs on same device, performance degrade significantly on too frequent flushing. You can consider increment flush interval to get better performance, but you need to pay more time on bookie server restart after failure.|60000|
|bookieDeathWatchInterval|Interval to watch whether bookie is dead or not, in milliseconds|1000|
|allowStorageExpansion|Allow the bookie storage to expand. Newly added ledger and index dirs must be empty.|false|
-|zkServers|A list of one of more servers on which zookeeper is running. The server list can be comma separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
+|metadataServiceUri|Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location.||
+|zkServers|Deprecated in favor of using `metadataServiceUri`. A list of one of more servers on which zookeeper is running. The server list can be comma separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
Review Comment:
```suggestion
|zkServers|Deprecated in favor of using `metadataServiceUri`. A list of one or more servers on which ZooKeeper is running. The server list can be comma-separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
```
```suggestion
|zkServers|Deprecated in favor of using `metadataServiceUri`. A list of one of more servers on which zookeeper is running. The server list can be comma separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
```
##########
conf/bookkeeper.conf:
##########
@@ -631,10 +631,10 @@ diskCheckInterval=10000
## Metadata Service settings
#############################################################################
-# metadata service uri that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location
+# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
# Examples:
-# - metadataServiceUri=metadata-store:zk:my-zk-1:2181
-# - metadataServiceUri=metadata-store:etcd:http://my-etcd:2379
+# - metadataServiceUri=zk://my-zk-1:2181/ledgers
+# - metadataServiceUri=etcd:http://my-etcd:2379
Review Comment:
FYI @momo-jun @daveduggins
##########
site2/docs/reference-configuration.md:
##########
@@ -72,7 +72,8 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|flushInterval|How long the interval to flush ledger index pages to disk, in milliseconds. Flushing index files will introduce much random disk I/O. If separating journal dir and ledger dirs each on different devices, flushing would not affect performance. But if putting journal dir and ledger dirs on same device, performance degrade significantly on too frequent flushing. You can consider increment flush interval to get better performance, but you need to pay more time on bookie server restart after failure.|60000|
|bookieDeathWatchInterval|Interval to watch whether bookie is dead or not, in milliseconds|1000|
|allowStorageExpansion|Allow the bookie storage to expand. Newly added ledger and index dirs must be empty.|false|
-|zkServers|A list of one of more servers on which zookeeper is running. The server list can be comma separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
+|metadataServiceUri|Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location.||
Review Comment:
```suggestion
|metadataServiceUri|Metadata service URI that BookKeeper uses for loading the corresponding metadata driver and resolving its metadata service location.||
```
```suggestion
|metadataServiceUri|Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location.||
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org