You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "scottyaslan (via GitHub)" <gi...@apache.org> on 2024/02/06 21:10:07 UTC
[PR] [NIFI-12748] apply panelClass to snackbars to apply lighter color to … [nifi]
scottyaslan opened a new pull request, #8365:
URL: https://github.com/apache/nifi/pull/8365
…the snackbar action text
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-12748] apply panelClass to snackbars to apply lighter color to … [nifi]
Posted by "rfellows (via GitHub)" <gi...@apache.org>.
rfellows merged PR #8365:
URL: https://github.com/apache/nifi/pull/8365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-12748] apply panelClass to snackbars to apply lighter color to … [nifi]
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #8365:
URL: https://github.com/apache/nifi/pull/8365#discussion_r1480848712
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/_app.component-theme.scss:
##########
@@ -27,8 +27,13 @@
// Get hues from palette
$primary-palette-500: mat.get-color-from-palette($primary-palette, 500);
+ $primary-palette-300: mat.get-color-from-palette($primary-palette, 300);
.splash {
background-color: $primary-palette-500;
}
+
+ .nifi-snackbar .mat-mdc-button:not(:disabled) .mdc-button__label {
+ color: $primary-palette-300;
+ }
Review Comment:
I think you mean $accent-palette-A400. I just updated the references to the primary palette A100 - A700 here: https://github.com/apache/nifi/pull/8364.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-12748] apply panelClass to snackbars to apply lighter color to … [nifi]
Posted by "rfellows (via GitHub)" <gi...@apache.org>.
rfellows commented on code in PR #8365:
URL: https://github.com/apache/nifi/pull/8365#discussion_r1480636980
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/_app.component-theme.scss:
##########
@@ -27,8 +27,13 @@
// Get hues from palette
$primary-palette-500: mat.get-color-from-palette($primary-palette, 500);
+ $primary-palette-300: mat.get-color-from-palette($primary-palette, 300);
.splash {
background-color: $primary-palette-500;
}
+
+ .nifi-snackbar .mat-mdc-button:not(:disabled) .mdc-button__label {
+ color: $primary-palette-300;
+ }
Review Comment:
@scottyaslan we probably also need a setting for the `:hover` state. ATM, the button highlight on hover isn't visible like it is in dark-mode.
Might want to add something like this
```
.nifi-snackbar .mat-mdc-button:hover {
background-color: $primary-palette-A400;
}
```
I don't love the color, but we use it for other button hover states.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org