You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aries.apache.org by ro...@apache.org on 2019/12/09 01:36:49 UTC
[aries-cdi] branch master updated: ARIES-1958 let implicit
extensions work even if no explicit extensions are required
This is an automated email from the ASF dual-hosted git repository.
rotty3000 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/aries-cdi.git
The following commit(s) were added to refs/heads/master by this push:
new 215dcd3 ARIES-1958 let implicit extensions work even if no explicit extensions are required
new 34a25c3 Merge pull request #25 from rotty3000/ARIES-1958
215dcd3 is described below
commit 215dcd3c022f9cbcc472aff2500c716e47a1a360
Author: Raymond Augé <ro...@apache.org>
AuthorDate: Fri Dec 6 11:33:58 2019 -0500
ARIES-1958 let implicit extensions work even if no explicit extensions are required
Signed-off-by: Raymond Augé <ro...@apache.org>
---
.../internal/container/ExtensionPhase.java | 56 +++++++++++-----------
1 file changed, 27 insertions(+), 29 deletions(-)
diff --git a/cdi-extender/src/main/java/org/apache/aries/cdi/container/internal/container/ExtensionPhase.java b/cdi-extender/src/main/java/org/apache/aries/cdi/container/internal/container/ExtensionPhase.java
index bb96c21..68028ad 100644
--- a/cdi-extender/src/main/java/org/apache/aries/cdi/container/internal/container/ExtensionPhase.java
+++ b/cdi-extender/src/main/java/org/apache/aries/cdi/container/internal/container/ExtensionPhase.java
@@ -53,17 +53,8 @@ public class ExtensionPhase extends Phase {
@Override
public boolean close() {
try (Syncro open = syncro.open()) {
- if (!extensionTemplates().isEmpty()) {
- if (_extensionTracker != null) {
- _extensionTracker.close();
-
- _extensionTracker = null;
- }
-
- return true;
- }
- else {
- return next.map(
+ if (extensionTemplates().isEmpty()) {
+ next.map(
next -> {
submit(next.closeOp(), next::close).onFailure(
f -> {
@@ -77,6 +68,14 @@ public class ExtensionPhase extends Phase {
}
).orElse(true);
}
+
+ if (_extensionTracker != null) {
+ _extensionTracker.close();
+
+ _extensionTracker = null;
+ }
+
+ return true;
}
}
@@ -93,29 +92,28 @@ public class ExtensionPhase extends Phase {
return false;
}
- if (!extensionTemplates().isEmpty()) {
- _extensionTracker = new ServiceTracker<>(
- containerState.bundleContext(), createExtensionFilter(), new ExtensionPhaseCustomizer());
+ _extensionTracker = new ServiceTracker<>(
+ containerState.bundleContext(), createExtensionFilter(), new ExtensionPhaseCustomizer());
- _extensionTracker.open();
+ _extensionTracker.open();
- return true;
- }
- else {
- return next.map(
- next -> {
- submit(next.openOp(), next::open).onFailure(
- f -> {
- _log.error(l -> l.error("CCR Error in extension OPEN on {}", bundle(), f));
+ if (extensionTemplates().isEmpty()) {
+ next.map(
+ next -> {
+ submit(next.openOp(), next::open).onFailure(
+ f -> {
+ _log.error(l -> l.error("CCR Error in extension OPEN on {}", bundle(), f));
- error(f);
- }
- );
+ error(f);
+ }
+ );
- return true;
- }
- ).orElse(true);
+ return true;
+ }
+ ).orElse(true);
}
+
+ return true;
}
}