You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org> on 2011/04/04 16:14:05 UTC
[jira] [Created] (KARAF-554) Add karaf version in system properties
and display in shell:info command output
Add karaf version in system properties and display in shell:info command output
-------------------------------------------------------------------------------
Key: KARAF-554
URL: https://issues.apache.org/jira/browse/KARAF-554
Project: Karaf
Issue Type: Improvement
Reporter: Jean-Baptiste Onofré
Fix For: 2.2.1, 3.0.0
shell:info command doesn't display the current running version of Karaf.
It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018340#comment-13018340 ]
Jean-Baptiste Onofré commented on KARAF-554:
--------------------------------------------
Fixed on trunk: revision 1091064.
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré resolved KARAF-554.
----------------------------------------
Resolution: Fixed
Fixed also on karaf-2.2.x: revision 1091088.
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Achim Nierbeck (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017896#comment-13017896 ]
Achim Nierbeck commented on KARAF-554:
--------------------------------------
+1 for A, C could be an alternative but A should be favored. This way we may also add it to the web-console later on :)
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017823#comment-13017823 ]
Andreas Pieber commented on KARAF-554:
--------------------------------------
mhm, just give this a look...
1) if we have a karaf.version sys property adding it to shell:info is not more than adding
{code}
printValue("Karaf version", maxNameLen, System.getProperty("karaf.version"));
{code}
The question is rather: where do we want to set the version. I don't think we want to have it set in the bat-files. Rather we can (A) either define it in systems.properties (I think this should be the easiest version). (B) Alternatively we can retrieve it from the bundles and set it AFTER startup. (C) Packing a config file directly into main (which could be pre-processed by maven and read by main) is another option.
I personally would like to go for (A) or (C). WDYT?
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017824#comment-13017824 ]
Andreas Pieber commented on KARAF-554:
--------------------------------------
btw, IMHO this feature is not that important and can be delayed to 2.2.2?
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018218#comment-13018218 ]
Jean-Baptiste Onofré commented on KARAF-554:
--------------------------------------------
I was more thinking about adding karaf.version in Main (main/src/main/java/org/apache/karaf/main/Main).
I propose the use the following code snippet:
Package p = Package.getPackage("org.apache.karaf");
if (p != null) {
System.getProperties().put("karaf.version", p.getImplementationVersion());
}
As you said, the shell:info will only display the karaf.version property.
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-554 started by Jean-Baptiste Onofré.
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré reassigned KARAF-554:
------------------------------------------
Assignee: Jean-Baptiste Onofré
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-554) Add karaf version in system
properties and display in shell:info command output
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018224#comment-13018224 ]
Andreas Pieber commented on KARAF-554:
--------------------------------------
Sounds reasonable to me. +1
I think this is easy enough to be included into 2.2.1 (although not that important I think :)) Do you want to include it yourself or should I add it while I'm on it?
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KARAF-554) Add karaf version in system properties
and display in shell:info command output
Posted by "Jamie goodyear (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear closed KARAF-554.
--------------------------------
> Add karaf version in system properties and display in shell:info command output
> -------------------------------------------------------------------------------
>
> Key: KARAF-554
> URL: https://issues.apache.org/jira/browse/KARAF-554
> Project: Karaf
> Issue Type: Improvement
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 2.2.1, 3.0.0
>
>
> shell:info command doesn't display the current running version of Karaf.
> It could be helpful in some user scripts to define an action depending of the Karaf instance (as we have uname -a under Unix :)).
> To be used programmatically, Karaf version should also be stored in system properties (as we have karaf.home, karaf.base, karaf.data and karaf.instances properties).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira