You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/28 05:49:46 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5365: Revert "sim: add CONFIG_SIM_STACKSIZE_ADJUSTMENT to reduce variability"

xiaoxiang781216 commented on pull request #5365:
URL: https://github.com/apache/incubator-nuttx/pull/5365#issuecomment-1023908065


   > ## Summary
   > This reverts commit [6b5a7a7](https://github.com/apache/incubator-nuttx/commit/6b5a7a73ba76671c81dc70485befb5ed5e818fe0).
   > 
   > Because:
   > 
   > * it broke existing configurations.
   
   could you point out which config broken?
   
   > * it makes stack-related api very confusing.
   >   eg. the "stack_size" argument of nxtask_init has different meanings
   >   depending on "stack".
   >   eg. pthread_attr_setstack and pthread_attr_setstacksize
   > * stacksize is inherently arch-dependent.
   
   Yes, that's why the adjust is located in arch/sim.
   
   >   the goal to share the same stack size configurations among archs
   >   is questionable.
   
   As I explain no one try to the same stack config for all arch, I just want to fix sim problem.
   
   > 
   > ## Impact
   > sim
   > 
   > ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org