[GitHub] [apisix] tokers commented on a diff in pull request #7006: feat(ops): check process running with posix.signal insteadof lsof

[GitBox <gi...@apache.org>]

tokers commented on code in PR #7006:
URL: https://github.com/apache/apisix/pull/7006#discussion_r867570784


##########
apisix/cli/ops.lua:
##########
@@ -728,14 +729,16 @@ local function start(env, ...)
     local pid = util.read_file(pid_path)
     pid = tonumber(pid)
     if pid then
-        local lsof_cmd = "lsof -p " .. pid
-        local res, err = util.execute_cmd(lsof_cmd)
-        if not (res and res == "") then
-            if not res then
-                print(err)
-            else
-                print("APISIX is running...")
-            end
+        local signone = 0

Review Comment:
   Better to add a test case to cover the changes. You can find some references from the `t/cli/` directory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org