You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/12/16 05:51:11 UTC

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2781: HBASE-25400 [Flakey Tests] branch-2 TestRegionMoveAndAbandon

huaxiangsun commented on a change in pull request #2781:
URL: https://github.com/apache/hbase/pull/2781#discussion_r543993675



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java
##########
@@ -102,6 +102,7 @@ public void test() throws Exception {
     LOG.info("Killing RS {}", rs1.getServerName());
     // Stop RS1
     cluster.killRegionServer(rs1.getServerName());
+    UTIL.waitFor(30_000, () -> rs1.isStopped() && !rs1.isAlive());

Review comment:
       Would it be better to increase the following to 60seconds? If let's say rs1 is stopped immediately, but 30 seconds is not enough for namespace table to be online. Increase the following to 60 seconds will make sure that enough time is waited.
    UTIL.waitTableAvailable(TableName.NAMESPACE_TABLE_NAME, 60_000);




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org