[GitHub] [inlong] e-mhui commented on a diff in pull request #7694: [INLONG-7693][Sort] MySQL CDC Connector supports specifying field synchronization

["e-mhui (via GitHub)" <gi...@apache.org>]

e-mhui commented on code in PR #7694:
URL: https://github.com/apache/inlong/pull/7694#discussion_r1160419451


##########
inlong-sort/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/source/reader/MySqlRecordEmitter.java:
##########
@@ -112,7 +119,8 @@ public void emitRecord(SourceRecord element, SourceOutput<T> output, MySqlSplitS
             for (TableChange tableChange : changes) {
                 splitState.asBinlogSplitState().recordSchema(tableChange.getId(), tableChange);
                 if (includeSchemaChanges) {
-                    outputDdlElement(element, output, splitState, tableChange);
+                    TableChange newTableChange = ColumnFilterUtil.createTableChange(tableChange, columnNameFilter);

Review Comment:
   Here is the output of schema changes, but you have used a column filter which may affect the accuracy of the results.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org