You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/12/17 19:30:22 UTC

[GitHub] [storm] RuiLi8080 opened a new pull request #3364: [STORM-3725] make DRPCSpout support real async connections

RuiLi8080 opened a new pull request #3364:
URL: https://github.com/apache/storm/pull/3364


   ## What is the purpose of the change
   
   Fix DRPC Spout SPOF to handle DRPC connections in a real async fashion
   
   ## How was the change tested
   
   Launching BasicDRPC topo in dev cluster with 2 DRPC servers.
   
   Both DRPC servers are down, worker will not come up
   Only 1 DRPC server is up, fail to create client for the down server and work well with the other up server
   Both server are up. After worker is up, kill the servers. Worker will not fail but keep reconnecting until one of the server is back up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] bipinprasad commented on pull request #3364: [STORM-3725] make DRPCSpout support real async connections

Posted by GitBox <gi...@apache.org>.
bipinprasad commented on pull request #3364:
URL: https://github.com/apache/storm/pull/3364#issuecomment-749267107


   That is by design, so that workers can still come up regardless of DRPC status. Messages will be processed when one or more of the DRPC servers are available.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] Ethanlm commented on pull request #3364: [STORM-3725] make DRPCSpout support real async connections

Posted by GitBox <gi...@apache.org>.
Ethanlm commented on pull request #3364:
URL: https://github.com/apache/storm/pull/3364#issuecomment-749345658


   Yeah I understand. 
   
   I should have been more clear.  I meant to ask @RuiLi8080 to change the statement.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] Ethanlm merged pull request #3364: [STORM-3725] make DRPCSpout support real async connections

Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3364:
URL: https://github.com/apache/storm/pull/3364


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] RuiLi8080 commented on pull request #3364: [STORM-3725] make DRPCSpout support real async connections

Posted by GitBox <gi...@apache.org>.
RuiLi8080 commented on pull request #3364:
URL: https://github.com/apache/storm/pull/3364#issuecomment-749384428


   @Ethanlm Updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] Ethanlm commented on pull request #3364: [STORM-3725] make DRPCSpout support real async connections

Posted by GitBox <gi...@apache.org>.
Ethanlm commented on pull request #3364:
URL: https://github.com/apache/storm/pull/3364#issuecomment-749208061


   > Both DRPC servers are down, worker will not come up
   
   Is it valid? From the code, it seems that the worker can still come up since it is not blocked on the `open` method


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org