[GitHub] apeforest opened a new pull request #12023: [MXNET-770] Fix flaky test: test_factorization_machine_module

[GitBox <gi...@apache.org>]

apeforest opened a new pull request #12023: [MXNET-770] Fix flaky test: test_factorization_machine_module
URL: https://github.com/apache/incubator-mxnet/pull/12023
 
 
   ## Description ##
   Fix flaky test test_factorization_machine_module by removing the accuracy tests for adam and adagrad and only test sgd in this unit test. Created a test_sparse_fm.py test in tests/python/training to test end-to-end training accuracy for various optimizers.
   Issue reported in #11704 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - Get rid of fixed seed in test and also removed tests for other optimizers
   - Created an end-to-end test in tests/python/train folder.
   
   ## Comments ##
   - Discussed the change with test owner @eric-haibin-lin 
   - Passed with 10K tests in CPU and GPU.
   CPU:
   ```
   ----------------------------------------------------------------------
   Ran 1 test in 8419.965s
   
   OK
   ```
   GPU
   ```
   ----------------------------------------------------------------------
   Ran 1 test in 5697.623s
   
   OK
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services