You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "onichols-pivotal (GitHub)" <gi...@apache.org> on 2018/10/30 19:22:45 UTC

[GitHub] [geode] onichols-pivotal opened pull request #2748: deploy_meta enhancements

* currently deploy_meta infers the branch name with no way to override.  print this with the other default variables and allow to be overridden if necessary like the other defaults (for example if your local branch name is tracking a remote branch that is named differently)
* when local overrides are not set up, print a kinder message about how to set them up
* handle 'pending' status for concourse jobs

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [n/a] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2748 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] smgoller closed pull request #2748: deploy_meta enhancements

Posted by "smgoller (GitHub)" <gi...@apache.org>.
[ pull request closed by smgoller ]

[ Full content available at: https://github.com/apache/geode/pull/2748 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] onichols-pivotal commented on issue #2748: deploy_meta enhancements

Posted by "onichols-pivotal (GitHub)" <gi...@apache.org>.
@smgoller please review and merge

[ Full content available at: https://github.com/apache/geode/pull/2748 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org