You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/07/01 15:44:00 UTC

[jira] [Commented] (AIRFLOW-4864) Don't call load_test_configuration multiple times

    [ https://issues.apache.org/jira/browse/AIRFLOW-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876286#comment-16876286 ] 

ASF subversion and git services commented on AIRFLOW-4864:
----------------------------------------------------------

Commit 6ae5f2b69a85346bc82c35b1e930dd4469436b9e in airflow's branch refs/heads/master from Ash Berlin-Taylor
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=6ae5f2b ]

[AIRFLOW-4864] Remove calls to load_test_config (#5502)

We already set the environment variable in the test runner so that
airflow.configuration will do this -- we don't need to do it again

> Don't call load_test_configuration multiple times
> -------------------------------------------------
>
>                 Key: AIRFLOW-4864
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4864
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: tests
>    Affects Versions: 2.0.0
>            Reporter: Ash Berlin-Taylor
>            Assignee: Ash Berlin-Taylor
>            Priority: Minor
>
> We have a pattern that many test files have cargo-culted from each other to call {{load_test_configuration}}, either at the module level, or inside the {{setUp}} of the test classes.
> This isn't needed - we already load the test config from the environment variable we set in travis, so this just causes a (tiny) delay.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)