You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/21 08:50:37 UTC
[GitHub] [camel-website] Siyubu opened a new pull request #253: Toolbar and
panel background color
Siyubu opened a new pull request #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253
1. Changed toolbar background color
2. Changed panel menu background color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd commented on a change in pull request #253:
Toolbar and panel background color
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#discussion_r396100388
##########
File path: README.md
##########
@@ -31,6 +31,21 @@ described in section ["Build with Maven"](#build-with-maven).
### Preparing the tools
+### Chocolatey
Review comment:
This is not related to your PR. It seems you mixed things up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-603311082
@Siyubu I understand that you encounter difficulties in contributing, a lot of this is new and challenging. Honestly we did not expect this many applicants to be interested in contributing and we it's been a challenge to keep up and help everyone that needs help. I can direct you to the [README](https://github.com/apache/camel-website/blob/master/README.md) file in the project that explains how to get started, [contributing guide](https://camel.apache.org/manual/latest/contributing.html) on the website and [getting started](https://help.github.com/en/github/getting-started-with-github) with GitHub.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-603256479
Thanks to constantly give me feedback. As it was my first time to
contribute on open sources and I was not familiar with git flow it isn't
been easy to me. Now, I would want to ask how to open issue on Jira.
While navigating
on apache website I saw pages that don't have toolbars and right navigation
bar such as support and user stories from community
*Solange Iyubu*
Student
Carnegie Mellon University in Africa
Tel: +250 785 562 715
On Tue, Mar 24, 2020 at 1:32 PM Zoran Regvart <no...@github.com>
wrote:
> Closed #253 <https://github.com/apache/camel-website/pull/253>.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-website/pull/253#event-3159240220>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALVC76WHA4KLRYAUSZCMDKLRJCK3BANCNFSM4LQ24SWA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-604951276
@Siyubu I see that you're trying to send emails with attachments here. This will not work as you're replying to GitHub sent email and only text of your reply is sent here.
To discuss development issues and as instructed in the [contributing guide](https://camel.apache.org/manual/latest/contributing.html) please subscribe to the [developer mailing list](https://camel.apache.org/community/mailing-list/) and ask questions there.
It is more helpful if you paste the text of the error you experience to an on-line service such as https://gist.github.com/ or https://pastebin.com/. Please do not send screenshots of text.
We're also conversing on a closed pull request at https://github.com/apache/camel-website/pull/253 please bare that in mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd commented on a change in pull request #253:
Toolbar and panel background color
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#discussion_r396100425
##########
File path: antora-ui-camel/package.json
##########
@@ -72,6 +72,7 @@
"pnp": true
},
"dependencies": {
- "algoliasearch": "^4.0.3"
+ "algoliasearch": "^4.0.3",
Review comment:
This too, it's not related to your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-602223346
> I don't think this is correct: there are commits from other PR inside and conflicts. Also what is the reason to change the color of the navbar, is there an issue for this? Improvements are ok, bug fixes too, opening PRs just for opening PRs, it's not.
I was working on Improving color contrast which is camel-14700 issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-603186473
Same as in #235, you either need to work from a single branch and on one pull request at a time, or work from multiple branches for multiple pull requests.
Please separate the changes into multiple branches and create pull request for each change separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-604989063
Okay, I am sorry for the inconveniences
*Solange Iyubu*
Student
Carnegie Mellon University in Africa
Tel: +250 785 562 715
On Fri, Mar 27, 2020 at 1:30 PM Zoran Regvart <no...@github.com>
wrote:
> @Siyubu <https://github.com/Siyubu> I see that you're trying to send
> emails with attachments here. This will not work as you're replying to
> GitHub sent email and only text of your reply is sent here.
>
> To discuss development issues and as instructed in the contributing guide
> <https://camel.apache.org/manual/latest/contributing.html> please
> subscribe to the developer mailing list
> <https://camel.apache.org/community/mailing-list/> and ask questions
> there.
>
> It is more helpful if you paste the text of the error you experience to an
> on-line service such as https://gist.github.com/ or https://pastebin.com/.
> Please do not send screenshots of text.
>
> We're also conversing on a closed pull request at #253
> <https://github.com/apache/camel-website/pull/253> please bare that in
> mind.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-website/pull/253#issuecomment-604951276>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALVC76TLT4753GVTWDABUQTRJSE47ANCNFSM4LQ24SWA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-604887394
Hello
I tried to read the documents above and follow instructions. however IO
can't building camel using maven, I am getting plugins error and when I
try to debug using mvn -x I am getting the information attached on this
email. I would want your help
*Solange Iyubu*
Student
Carnegie Mellon University in Africa
Tel: +250 785 562 715
On Tue, Mar 24, 2020 at 5:35 PM Zoran Regvart <no...@github.com>
wrote:
> @Siyubu <https://github.com/Siyubu> I understand that you encounter
> difficulties in contributing, a lot of this is new and challenging.
> Honestly we did not expect this many applicants to be interested in
> contributing and we it's been a challenge to keep up and help everyone that
> needs help. I can direct you to the README
> <https://github.com/apache/camel-website/blob/master/README.md> file in
> the project that explains how to get started, contributing guide
> <https://camel.apache.org/manual/latest/contributing.html> on the website
> and getting started
> <https://help.github.com/en/github/getting-started-with-github> with
> GitHub.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-website/pull/253#issuecomment-603311082>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALVC76UMJ7THHLACLPCLF5DRJDHLZANCNFSM4LQ24SWA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-602226386
The yarn.lock doesn't seem correct anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart closed pull request #253: Toolbar and
panel background color
Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #253: Toolbar and panel
background color
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #253: Toolbar and panel background color
URL: https://github.com/apache/camel-website/pull/253#issuecomment-603273721
I finally found how to open an issue. however, I can't access camel
websites .html files to be able to add toolbar breadcrumbs on support file.
I would want your help
*Solange Iyubu*
Student
Carnegie Mellon University in Africa
Tel: +250 785 562 715
On Tue, Mar 24, 2020 at 4:01 PM Solange Iyubu <so...@gmail.com>
wrote:
> Thanks to constantly give me feedback. As it was my first time to
> contribute on open sources and I was not familiar with git flow it isn't
> been easy to me. Now, I would want to ask how to open issue on Jira. While navigating
> on apache website I saw pages that don't have toolbars and right navigation
> bar such as support and user stories from community
> *Solange Iyubu*
>
> Student
>
> Carnegie Mellon University in Africa
>
> Tel: +250 785 562 715
>
>
> On Tue, Mar 24, 2020 at 1:32 PM Zoran Regvart <no...@github.com>
> wrote:
>
>> Closed #253 <https://github.com/apache/camel-website/pull/253>.
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/camel-website/pull/253#event-3159240220>, or
>> unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ALVC76WHA4KLRYAUSZCMDKLRJCK3BANCNFSM4LQ24SWA>
>> .
>>
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services