You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/01/16 07:35:23 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #4030: HBASE-26587 Introduce a new Admin API to change SFT implementation

Apache9 commented on a change in pull request #4030:
URL: https://github.com/apache/hbase/pull/4030#discussion_r785401649



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -2590,7 +2620,20 @@ String getOperationType() {
 
     @Override
     String getOperationType() {
-      return "ENABLE";
+      return "MODIFY";
+    }
+  }
+
+  private static class ModifyTableStoreFileTrackerProcedureBiConsumer
+    extends TableProcedureBiConsumer {
+
+    ModifyTableStoreFileTrackerProcedureBiConsumer(AsyncAdmin admin, TableName tableName) {
+      super(tableName);
+    }
+
+    @Override
+    String getOperationType() {
+      return "MODIFY_STORE_FILE_TRACKER";

Review comment:
       Because we use MODIFY instead of MODIFY_TABLE here, so I assume we just name it MODIFY_STORE_FILE_TRACKER is enough. I'm fine with changing it to MODIFY_TABLE_STORE_FILE_TRACKER




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org