[jira] [Commented] (NETBEANS-126) Browser icons needs to be re-instated

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NETBEANS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241899#comment-16241899 ] 

ASF GitHub Bot commented on NETBEANS-126:
-----------------------------------------

lbruun opened a new pull request #251: [NETBEANS-126] Re-instate browser icons
URL: https://github.com/apache/incubator-netbeans/pull/251
 
 
   Reinstates those browser icons that were originally removed from Oracle's donation to Apache. See [NETBEANS-126](https://issues.apache.org/jira/browse/NETBEANS-126) for more information.
   
   IANAL, but I _assume_ that we are allowed to distribute these icons as part of Apache NetBeans, but that Oracle didn't want them in the donation bundle as this is not their trademarks. Please validate assumption before merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Browser icons needs to be re-instated
> -------------------------------------
>
>                 Key: NETBEANS-126
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-126
>             Project: NetBeans
>          Issue Type: Bug
>            Reporter: lbruun
>            Assignee: lbruun
>            Priority: Minor
>              Labels: donation-fixes, pull-request-available
>         Attachments: css-editor-icons.png, nb-icon.png, web-browser-api-icons.png
>
>
> A number of browser icons were "removed" from the donation, in [this changeset|http://hg.netbeans.org/releases/rev/034a0c65c347?revcount=1500]. They weren't actually removed, rather they were all replaced with a dummy NetBeans icon. I think Oracle removed them because Oracle couldn't donate such icons, as they don't "own" these trademarks.
> Specifically they did:
> Removed from {{css.editor}}:
> !css-editor-icons.png!
> Removed from {{web.browser.api}}:
> !web-browser-api-icons.png!
> The above icons are all replaced with a dummy NetBeans icon: !nb-icon.png!
> I'll do a PR to re-instate these.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)