You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/15 08:12:53 UTC

[GitHub] [incubator-superset] kgabryje edited a comment on pull request #12042: refactor: Migrate react-select to Antd Select in Metrics and Filters popovers

kgabryje edited a comment on pull request #12042:
URL: https://github.com/apache/incubator-superset/pull/12042#issuecomment-745124461


   Thanks @rusackas, works like a charm! I needed to add some conditions when to display that labelText, because simply replacing placeholder with labelText did not work well in some cases, but other than that it seems ok! Would appreciate if you took another look
   ![image](https://user-images.githubusercontent.com/15073128/102187840-d1cf6f00-3eb4-11eb-8608-39fb4fd584b7.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org