You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by yaurthek <gi...@git.apache.org> on 2014/04/08 15:44:03 UTC
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
GitHub user yaurthek opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/36
fix the Windows 8 implementation of the getFile method
The storageFolder.getFileAsync(name) does not accept relative paths, only a simple file name...
see http://msdn.microsoft.com/en-us/library/windows/apps/windows.storage.storagefolder.getfileasync?cs-save-lang=1&cs-lang=javascript#code-snippet-1
I didn't check, but other methods might be affected similarly...
(accepting a relative path, but using methods only accepting a name)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yaurthek/cordova-plugin-file dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 22a42c97dfe4b454041ae710f2bcb03c02ca7d4f
Author: Melvyn <ml...@gismartware.com>
Date: 2014-04-08T13:33:42Z
fix the Windows 8 implementation of the getFile method
The storageFolder.getFileAsync(name) does not accept relative paths, only a simple file name...
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Posted by yaurthek <gi...@git.apache.org>.
Github user yaurthek commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-41490154
Hi, I'm just letting you know that my ICLA has been filed, and my name is present on the commiters index.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-46251564
This code is fully merged. Please close this pull request.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-40994122
Hi @yaurthek, thanks for the contributuion.
Have you signed the iCLA?
I do not see you listed on https://people.apache.org/committer-index.html
However, I'm not entirely sure what your name is.
If you haven't signed it, you can get more details here: http://cordova.apache.org/#contribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Posted by yaurthek <gi...@git.apache.org>.
Github user yaurthek closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-39853542
Looks like https://issues.apache.org/jira/browse/CB-6017 (and possibly also https://issues.apache.org/jira/browse/CB-6053)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Posted by yaurthek <gi...@git.apache.org>.
Github user yaurthek commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-41012223
Hi. Sorry, I was not aware of the ICLA.
I will sign it and send it as soon as possible.
My full name is Melvyn Laïly. (not on the list yet)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-41493185
Thanks, will merge Monday.
Just
> On Apr 27, 2014, at 12:21 AM, Melvyn <no...@github.com> wrote:
>
> Hi, I'm just letting you know that my ICLA has been filed, and my name is present on the commiters index.
>
> —
> Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---