You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Antonio Sanso (JIRA)" <ji...@apache.org> on 2012/07/20 12:06:33 UTC
[jira] [Created] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Antonio Sanso created SLING-2544:
------------------------------------
Summary: Restore tests included in the no longer existing JcrResourceResolverTest
Key: SLING-2544
URL: https://issues.apache.org/jira/browse/SLING-2544
Project: Sling
Issue Type: New Feature
Components: ResourceResolver
Reporter: Antonio Sanso
With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso updated SLING-2544:
---------------------------------
Attachment: SynchronousJcrResourceListener.java
JcrResourceResolverTest.java
Attached migrated tests. I have run them in the org.apache.sling.resourceresolver project but I am not sure is the right place where to have them due the dependencies to the org.apache.sling.jcr.resource module.
Those Junit tests might deserve a separate project.
Note:
all the original tests have been migrated successfully but test_attributes_from_session and test_resolve_with_sling_alias_limited_access. I have commented those tests for now and I'll investigate why they fail.
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443439#comment-13443439 ]
Justin Edelson commented on SLING-2544:
---------------------------------------
We can't really run these in a launched instance because they involve some internals. But they still belong in the IT "area" of the project.
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421287#comment-13421287 ]
Carsten Ziegeler commented on SLING-2544:
-----------------------------------------
Thanks for the work, Antonio!
As you commented we should not add them to the resourceresolver project due to the dependencies. I'm not 100% sure where to put this, but maybe the launchpad test services is a good place? I think these tests should run in a launed instance on the server side, so we always test the latest combination of the resourceresolver and jcr resource bundle
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443703#comment-13443703 ]
Justin Edelson commented on SLING-2544:
---------------------------------------
added this test to the integration-tests module in r1378407. It gets run (like all ITs) in the testing and/or testing-war projects.
Created a new package for this type of test: org.apache.sling.launchpad.local.integrationtest
open issue is how to coordinate bundle versions with this test (to Carsten's point)
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Assignee: Justin Edelson
> Fix For: Launchpad Testing 7
>
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2544) Restore tests included in the
no longer existing JcrResourceResolverTest
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421287#comment-13421287 ]
Carsten Ziegeler edited comment on SLING-2544 at 7/24/12 9:24 AM:
------------------------------------------------------------------
Thanks for the work, Antonio!
As you commented we should not add them to the resourceresolver project due to the dependencies. I'm not 100% sure where to put this, but maybe the launchpad test services is a good place? I think these tests should run in a launched instance on the server side, so we always test the latest combination of the resourceresolver and jcr resource bundle
was (Author: cziegeler):
Thanks for the work, Antonio!
As you commented we should not add them to the resourceresolver project due to the dependencies. I'm not 100% sure where to put this, but maybe the launchpad test services is a good place? I think these tests should run in a launed instance on the server side, so we always test the latest combination of the resourceresolver and jcr resource bundle
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-2544.
-----------------------------------
Resolution: Fixed
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: Launchpad, ResourceResolver, Testing
> Reporter: Antonio Sanso
> Assignee: Justin Edelson
> Fix For: Launchpad Testing 7
>
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-2544:
----------------------------------
Component/s: Testing
Launchpad
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: Launchpad, ResourceResolver, Testing
> Reporter: Antonio Sanso
> Assignee: Justin Edelson
> Fix For: Launchpad Testing 7
>
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson reassigned SLING-2544:
-------------------------------------
Assignee: Justin Edelson
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Assignee: Justin Edelson
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-2544:
----------------------------------
Fix Version/s: Launchpad Testing 7
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Assignee: Justin Edelson
> Fix For: Launchpad Testing 7
>
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2544) Restore tests included in the no
longer existing JcrResourceResolverTest
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443704#comment-13443704 ]
Justin Edelson commented on SLING-2544:
---------------------------------------
created some follow up issues:
SLING-2584
SLING-2585
SLING-2586
> Restore tests included in the no longer existing JcrResourceResolverTest
> -------------------------------------------------------------------------
>
> Key: SLING-2544
> URL: https://issues.apache.org/jira/browse/SLING-2544
> Project: Sling
> Issue Type: New Feature
> Components: Launchpad, ResourceResolver, Testing
> Reporter: Antonio Sanso
> Assignee: Justin Edelson
> Fix For: Launchpad Testing 7
>
> Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java
>
>
> With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been "lost in translation".
> I think it would be really useful to restore them specially for regression detection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira