You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/08/30 03:47:11 UTC
[GitHub] [iceberg] rawataaryan9 opened a new pull request #3052: Core : Fixing allowed null values for iceberg table properties
rawataaryan9 opened a new pull request #3052:
URL: https://github.com/apache/iceberg/pull/3052
The current iceberg table properties by design do not support any other value than non-null string values. However, due to a typo in the code, it allows a null value for a table property. Due to this we can store the value as null but breaks the read/load of iceberg table back due to non-null property values checks as part of metadata parsers.
This PR just updates the typo to ensure we cannot populate non-null values.
@rdblue @jackye1995 @aokolnychyi @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3052: Core : Fixing allowed null values for iceberg table properties
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3052:
URL: https://github.com/apache/iceberg/pull/3052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3052: Core : Fixing allowed null values for iceberg table properties
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3052:
URL: https://github.com/apache/iceberg/pull/3052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3052: Core : Fixing allowed null values for iceberg table properties
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3052:
URL: https://github.com/apache/iceberg/pull/3052#issuecomment-908417067
Thanks, @rawataaryan9! Looks good. I approved this to run tests and I'll merge when they pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3052: Core : Fixing allowed null values for iceberg table properties
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3052:
URL: https://github.com/apache/iceberg/pull/3052#issuecomment-908417067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3052: Core : Fixing allowed null values for iceberg table properties
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3052:
URL: https://github.com/apache/iceberg/pull/3052#issuecomment-908556812
Merged. I'm also marking this for inclusion in a patch release if we decide to make one. While it probably isn't reason in itself to do another release, it would be nice to fix this for people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org