You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/02/08 09:29:44 UTC

svn commit: r1873773 - in /pdfbox/branches/issue45: examples/src/main/java/org/apache/pdfbox/examples/pdmodel/ fontbox/src/main/java/org/apache/fontbox/ttf/

Author: tilman
Date: Sat Feb  8 09:29:43 2020
New Revision: 1873773

URL: http://svn.apache.org/viewvc?rev=1873773&view=rev
Log:
PDFBOX-4071: SonarQube fix; remove unneeded super()

Modified:
    pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/RubberStampWithImage.java
    pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/UsingTextMatrix.java
    pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/ttf/CmapSubtable.java

Modified: pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/RubberStampWithImage.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/RubberStampWithImage.java?rev=1873773&r1=1873772&r2=1873773&view=diff
==============================================================================
--- pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/RubberStampWithImage.java (original)
+++ pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/RubberStampWithImage.java Sat Feb  8 09:29:43 2020
@@ -47,7 +47,7 @@ public class RubberStampWithImage
     private static final String XOBJECT_DO = "Do\n";
     private static final String SPACE = " ";
 
-    private static final NumberFormat formatDecimal = NumberFormat.getNumberInstance( Locale.US );
+    private static final NumberFormat FORMATDECIMAL = NumberFormat.getNumberInstance( Locale.US );
 
     /**
      * Add a rubber stamp with an jpg image to every page of the given document.
@@ -139,17 +139,17 @@ public class RubberStampWithImage
         COSName xObjectId = resources.add(xobject);
 
         appendRawCommands( os, SAVE_GRAPHICS_STATE );
-        appendRawCommands( os, formatDecimal.format( width ) );
+        appendRawCommands( os, FORMATDECIMAL.format( width ) );
         appendRawCommands( os, SPACE );
-        appendRawCommands( os, formatDecimal.format( 0 ) );
+        appendRawCommands( os, FORMATDECIMAL.format( 0 ) );
         appendRawCommands( os, SPACE );
-        appendRawCommands( os, formatDecimal.format( 0 ) );
+        appendRawCommands( os, FORMATDECIMAL.format( 0 ) );
         appendRawCommands( os, SPACE );
-        appendRawCommands( os, formatDecimal.format( height ) );
+        appendRawCommands( os, FORMATDECIMAL.format( height ) );
         appendRawCommands( os, SPACE );
-        appendRawCommands( os, formatDecimal.format( x ) );
+        appendRawCommands( os, FORMATDECIMAL.format( x ) );
         appendRawCommands( os, SPACE );
-        appendRawCommands( os, formatDecimal.format( y ) );
+        appendRawCommands( os, FORMATDECIMAL.format( y ) );
         appendRawCommands( os, SPACE );
         appendRawCommands( os, CONCATENATE_MATRIX );
         appendRawCommands( os, SPACE );

Modified: pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/UsingTextMatrix.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/UsingTextMatrix.java?rev=1873773&r1=1873772&r2=1873773&view=diff
==============================================================================
--- pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/UsingTextMatrix.java (original)
+++ pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/pdmodel/UsingTextMatrix.java Sat Feb  8 09:29:43 2020
@@ -37,7 +37,6 @@ public class UsingTextMatrix
      */
     public UsingTextMatrix()
     {
-        super();
     }
 
     /**
@@ -100,7 +99,8 @@ public class UsingTextMatrix
             // text scaling and translation
             for (int i=0;i<10;i++)
             {
-                contentStream.setTextMatrix(new Matrix(12 + (i * 6), 0, 0, 12+(i*6), 100, 100+i*50));
+                contentStream.setTextMatrix(new Matrix(12f + (i * 6), 0, 0, 12f + (i * 6), 
+                                                       100, 100f + i * 50));
                 contentStream.showText(message + " " + i);
             }
             contentStream.endText();

Modified: pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/ttf/CmapSubtable.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/ttf/CmapSubtable.java?rev=1873773&r1=1873772&r2=1873773&view=diff
==============================================================================
--- pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/ttf/CmapSubtable.java (original)
+++ pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/ttf/CmapSubtable.java Sat Feb  8 09:29:43 2020
@@ -37,8 +37,8 @@ public class CmapSubtable implements Cma
 {
     private static final Log LOG = LogFactory.getLog(CmapSubtable.class);
 
-    private static final long LEAD_OFFSET = 0xD800 - (0x10000 >> 10);
-    private static final long SURROGATE_OFFSET = 0x10000 - (0xD800 << 10) - 0xDC00;
+    private static final long LEAD_OFFSET = 0xD800l - (0x10000 >> 10);
+    private static final long SURROGATE_OFFSET = 0x10000l - (0xD800 << 10) - 0xDC00;
 
     private int platformId;
     private int platformEncodingId;