You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/21 08:47:28 UTC

[GitHub] [ignite] timoninmaxim commented on a change in pull request #9846: IGNITE-16604: Fix GeoSpatial indexes for client nodes

timoninmaxim commented on a change in pull request #9846:
URL: https://github.com/apache/ignite/pull/9846#discussion_r830866510



##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/index/client/ClientInlineIndex.java
##########
@@ -148,7 +148,7 @@ public ClientInlineIndex(String idxName, int inlineSize) {
     /**
      * @return Exception about unsupported operation.
      */
-    private static IgniteException unsupported() {
+    public static IgniteException unsupported() {

Review comment:
       I'm not sure that it's OK to move this method to U class. This method is expected to be used only by client nodes. IMHO, the better option is an additional layer like `AbstractClientIndex` with this method. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org