You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/02/14 05:30:36 UTC

[kyuubi] branch master updated: [KYUUBI #4322] MySQL url configuration joiner should use `&` instead of `;`

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 16d4735c9 [KYUUBI #4322] MySQL url configuration joiner should use `&` instead of `;`
16d4735c9 is described below

commit 16d4735c92f7fde9b31e1831647bab2e058a5906
Author: Yikf <yi...@apache.org>
AuthorDate: Tue Feb 14 13:30:25 2023 +0800

    [KYUUBI #4322] MySQL url configuration joiner should use `&` instead of `;`
    
    ### _Why are the changes needed?_
    
    The mysql url configuration joiner should use `&` instead of `;`
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #4322 from Yikf/mysql-fe-test.
    
    Closes #4322
    
    8d289e793 [Yikf] The configuration joiner should use `&` instead of `;`
    
    Authored-by: Yikf <yi...@apache.org>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../test/scala/org/apache/kyuubi/server/mysql/MySQLJDBCTestHelper.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/MySQLJDBCTestHelper.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/MySQLJDBCTestHelper.scala
index a703b6b15..e6df1fb20 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/MySQLJDBCTestHelper.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/MySQLJDBCTestHelper.scala
@@ -42,7 +42,7 @@ trait MySQLJDBCTestHelper extends JDBCTestHelper {
       if (jdbcConfigs.isEmpty) {
         ""
       } else {
-        "?" + jdbcConfigs.map(kv => kv._1 + "=" + kv._2).mkString(";")
+        "?" + jdbcConfigs.map(kv => kv._1 + "=" + kv._2).mkString("&")
       }
     jdbcUrl + jdbcConfStr
   }