[jira] Commented: (HIVE-716) Web Interface wait/notify, interface changes

["Namit Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750193#action_12750193 ] 

Namit Jain commented on HIVE-716:
---------------------------------

@Edward, I committed 752 just now. Can you regenerate the patch - I would like to get it in before releasing 0.4

> Web Interface wait/notify, interface changes
> --------------------------------------------
>
>                 Key: HIVE-716
>                 URL: https://issues.apache.org/jira/browse/HIVE-716
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Web UI
>         Environment: All
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>         Attachments: hive-716-2.diff, hive-716-3.diff, hive-716-4.diff, hive-716.diff, hwi_query_box.png
>
>
> In TestHWISessionItem 
> Asserts are backwards
> {noformat}
> assertEquals(  searchItem.getQueryRet(), 0);
> {noformat}
> Should be
> {noformat}
> assertEquals( zero , searchItem.getQueryRet());
> {noformat}
> Wait/notify semantics can be added. This is helpful for end user, and cleaner in the test case.
> {noformat}
> while (user1_item2.getStatus() != HWISessionItem.WebSessionItemStatus.QUERY_COMPLETE) {
>   Thread.sleep(1);
> }
> {noformat}
> {noformat}
> synchronized (user1_item2.runnable) {
>   while (user1_item2.getStatus() != HWISessionItem.WebSessionItemStatus.QUERY_COMPLETE) {
>      user1_item2.runnable.wait();
>   }
> }
> {noformat}
> The text box in the web interface should accept multiple queries separated by ';' like the cli does. This will add more usability. No need for separate set processor pages. 
> setQuery(String) is replaced by setQueries(List<String>)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.