You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/10 08:33:10 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #5708: xtensa: small improvements around using the software interrupt.
Ouss4 opened a new pull request #5708:
URL: https://github.com/apache/incubator-nuttx/pull/5708
## Summary
- Use `rsync` when manipulating interrupt registers, this is the recommended instruction by the TRM.
- Co-processor state was restored two times in `xtensa_exit`.
## Impact
Xtensa chips
## Testing
Tested the defconfigs of all ESP32xx chips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5708: xtensa: small improvements around using the software interrupt.
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5708:
URL: https://github.com/apache/incubator-nuttx/pull/5708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5708: xtensa: small improvements around using the software interrupt.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5708:
URL: https://github.com/apache/incubator-nuttx/pull/5708#issuecomment-1063813103
@zhuyanlin111 could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5708: xtensa: small improvements around using the software interrupt.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5708:
URL: https://github.com/apache/incubator-nuttx/pull/5708#discussion_r823479569
##########
File path: arch/xtensa/src/common/xtensa_cpuint.S
##########
@@ -82,6 +82,7 @@ xtensa_enable_cpuint:
s32i a5, a2, 0 /* shadow |= mask */
wsr a5, INTENABLE /* Set CPU INTENABLE to shadow */
+ rsync
Review comment:
space-.tab
##########
File path: arch/xtensa/src/common/xtensa_cpuint.S
##########
@@ -122,6 +123,7 @@ xtensa_disable_cpuint:
s32i a5, a2, 0 /* shadow &= ~mask */
wsr a5, INTENABLE /* Set CPU INTENABLE to shadow */
+ rsync
Review comment:
space->tab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org