You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by pt...@apache.org on 2018/01/22 17:41:33 UTC
[27/38] storm git commit: STORM-2153: Use StringBuilder instead of
String.format for composing metric names
STORM-2153: Use StringBuilder instead of String.format for composing metric names
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/8bf7252e
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/8bf7252e
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/8bf7252e
Branch: refs/heads/1.x-branch
Commit: 8bf7252ebd36e540515fedd70fb8c2004c1e4364
Parents: 44cd8ac
Author: P. Taylor Goetz <pt...@gmail.com>
Authored: Wed Jan 10 13:43:33 2018 -0500
Committer: P. Taylor Goetz <pt...@gmail.com>
Committed: Wed Jan 10 13:43:33 2018 -0500
----------------------------------------------------------------------
.../storm/metrics2/StormMetricRegistry.java | 60 +++++++++++++-------
1 file changed, 38 insertions(+), 22 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/8bf7252e/storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java b/storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java
index 789367b..aea4539 100644
--- a/storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java
+++ b/storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java
@@ -118,7 +118,6 @@ public class StormMetricRegistry {
}
-
public static void stop(){
for(StormReporter sr : REPORTERS){
sr.stop();
@@ -126,32 +125,49 @@ public class StormMetricRegistry {
}
public static String metricName(String name, String stormId, String componentId, String streamId, String executorId, Integer workerPort){
- return String.format("storm.worker.%s.%s.%s.%s.%s.%s-%s",
- stormId,
- hostName,
- dotToUnderScore(componentId),
- dotToUnderScore(streamId),
- dotToUnderScore(executorId),
- workerPort,
- name);
+ StringBuilder sb = new StringBuilder("storm.worker.");
+ sb.append(stormId);
+ sb.append(".");
+ sb.append(hostName);
+ sb.append(".");
+ sb.append(dotToUnderScore(componentId));
+ sb.append(".");
+ sb.append(dotToUnderScore(streamId));
+ sb.append(".");
+ sb.append(dotToUnderScore(executorId));
+ sb.append(".");
+ sb.append(workerPort);
+ sb.append("-");
+ sb.append(name);
+ return sb.toString();
}
- public static String metricName(String name, String stormId, String componentId, Integer workerPort){
- return String.format("storm.worker.%s.%s.%s.%s-%s",
- stormId,
- hostName,
- dotToUnderScore(componentId),
- workerPort,
- name);
+ public static String metricName(String name, String stormId, String componentId, Integer workerPort) {
+ StringBuilder sb = new StringBuilder("storm.worker.");
+ sb.append(stormId);
+ sb.append(".");
+ sb.append(hostName);
+ sb.append(".");
+ sb.append(dotToUnderScore(componentId));
+ sb.append(".");
+ sb.append(workerPort);
+ sb.append("-");
+ sb.append(name);
+ return sb.toString();
}
public static String metricName(String name, TopologyContext context){
- return String.format("storm.topology.%s.%s.%s.%s.%s-%s",
- context.getStormId(),
- hostName,
- dotToUnderScore(context.getThisComponentId()),
- context.getThisWorkerPort(),
- name);
+ StringBuilder sb = new StringBuilder("storm.topology.");
+ sb.append(context.getStormId());
+ sb.append(".");
+ sb.append(hostName);
+ sb.append(".");
+ sb.append(dotToUnderScore(context.getThisComponentId()));
+ sb.append(".");
+ sb.append(context.getThisWorkerPort());
+ sb.append("-");
+ sb.append(name);
+ return sb.toString();
}
private static String dotToUnderScore(String str){