You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/01 16:41:43 UTC

[GitHub] [superset] michael-s-molina commented on a change in pull request #19462: chore: Remove FilterBox.less

michael-s-molina commented on a change in pull request #19462:
URL: https://github.com/apache/superset/pull/19462#discussion_r840755345



##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -91,6 +97,30 @@ const defaultProps = {
   instantFiltering: false,
 };
 
+const StyledFilterContainer = styled.div`
+  display: flex;

Review comment:
       [No need to use theme the hard way](https://github.com/apache/superset/wiki/Emotion-Styling-Guidelines-and-Best-Practices#no-need-to-use-theme-the-hard-way) 😉 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org