You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/09 09:02:15 UTC
[GitHub] [spark] grundprinzip commented on a diff in pull request #38174: [SPARK-40717][CONNECT] Support Column Alias in the Connect DSL
grundprinzip commented on code in PR #38174:
URL: https://github.com/apache/spark/pull/38174#discussion_r990758968
##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -165,4 +166,9 @@ message Expression {
message QualifiedAttribute {
string name = 1;
}
+
+ message Alias {
Review Comment:
why wouldn't this be a common attribute of Expression instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org