You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/16 09:28:42 UTC
[GitHub] [incubator-doris] kangpinghuang opened a new pull request #3336:
fix cooldown timestamp bug
kangpinghuang opened a new pull request #3336: fix cooldown timestamp bug
URL: https://github.com/apache/incubator-doris/pull/3336
when add a parition with storage_cooldown_time property like this:
alter table tablexxx ADD PARTITION p20200421 VALUES LESS THAN("1588262400") ("storage_medium" = "SSD", "storage_cooldown_time" = "2020-05-01 00:00:00");
and show partitions from tablexxx;
the CooldownTime is wrong: 2610-02-17 10:16:40, and what is more, the storage migration is based on the wrong timestamp.
The reason is that the result of DateLiteral.getLongValue is not timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #3336: fix
cooldown timestamp bug
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #3336: fix cooldown timestamp bug
URL: https://github.com/apache/incubator-doris/pull/3336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on issue #3336: fix cooldown
timestamp bug
Posted by GitBox <gi...@apache.org>.
yiguolei commented on issue #3336: fix cooldown timestamp bug
URL: https://github.com/apache/incubator-doris/pull/3336#issuecomment-614535584
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#3336: fix cooldown timestamp bug
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3336: fix cooldown timestamp bug
URL: https://github.com/apache/incubator-doris/pull/3336#discussion_r409560532
##########
File path: fe/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
##########
@@ -110,7 +110,7 @@ public static DataProperty analyzeDataProperty(Map<String, String> properties, D
} else if (!hasCooldown && key.equalsIgnoreCase(PROPERTIES_STORAGE_COLDOWN_TIME)) {
hasCooldown = true;
DateLiteral dateLiteral = new DateLiteral(value, Type.DATETIME);
- coolDownTimeStamp = dateLiteral.getLongValue();
+ coolDownTimeStamp = dateLiteral.unixTimestamp(TimeUtils.getTimeZone());
Review comment:
Please add a UT for this bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org