You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/29 08:36:06 UTC
[GitHub] [airflow] feluelle commented on a change in pull request #9057: Update Breeze Documentation to have WSL 2 Instructions instead of WSL 1
feluelle commented on a change in pull request #9057:
URL: https://github.com/apache/airflow/pull/9057#discussion_r432337561
##########
File path: BREEZE.rst
##########
@@ -78,36 +78,46 @@ Docker Compose
- **Permissions**: Configure to run the ``docker-compose`` command.
-Docker in WSL
Review comment:
Actually since WSL 1 will still be supported. I would recommend to keep "Docker in WSL 1". There are also some notes when you want WSL 1 instead of 2. https://docs.microsoft.com/en-us/windows/wsl/compare-versions#exceptions-for-using-wsl-1-rather-than-wsl-2
##########
File path: BREEZE.rst
##########
@@ -78,36 +78,46 @@ Docker Compose
- **Permissions**: Configure to run the ``docker-compose`` command.
-Docker in WSL
--------------
+Docker in WSL 2
+---------------
+
+- **WSL 2 installation** :
+ Install WSL 2 and a Linux Distro (e.g. Ubuntu) see
+ `WSL 2 Installation Guide <https://docs.microsoft.com/en-us/windows/wsl/install-win10>`_ for details.
-- **WSL installation** :
- `WSL Installation Guide <https://docs.microsoft.com/en-us/windows/wsl/install-win10>`_ for details.
+- **Docker Desktop installation** :
+ Install Docker Desktop for Windows. For Windows Home follow the
+ `Docker Windows Home Installtion Guide <https://docs.docker.com/docker-for-windows/install-windows-home>`_.
Review comment:
```suggestion
`Docker Windows Home Installation Guide <https://docs.docker.com/docker-for-windows/install-windows-home>`_.
```
##########
File path: BREEZE.rst
##########
@@ -78,36 +78,46 @@ Docker Compose
- **Permissions**: Configure to run the ``docker-compose`` command.
-Docker in WSL
--------------
+Docker in WSL 2
+---------------
+
+- **WSL 2 installation** :
+ Install WSL 2 and a Linux Distro (e.g. Ubuntu) see
+ `WSL 2 Installation Guide <https://docs.microsoft.com/en-us/windows/wsl/install-win10>`_ for details.
-- **WSL installation** :
- `WSL Installation Guide <https://docs.microsoft.com/en-us/windows/wsl/install-win10>`_ for details.
+- **Docker Desktop installation** :
+ Install Docker Desktop for Windows. For Windows Home follow the
+ `Docker Windows Home Installtion Guide <https://docs.docker.com/docker-for-windows/install-windows-home>`_.
+ For Windows Pro, Enterprise, or Education follow the
+ `Docker Windows Installtion Guide <https://docs.docker.com/docker-for-windows/install/>`_.
Review comment:
```suggestion
`Docker Windows Installation Guide <https://docs.docker.com/docker-for-windows/install/>`_.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org