[GitHub] [ozone] smengcl commented on pull request #2075: HDDS-5019. Fix Inconsistent BucketName problem when use tmp volume an…

[GitBox <gi...@apache.org>]

smengcl commented on pull request #2075:
URL: https://github.com/apache/ozone/pull/2075#issuecomment-806377695


   Thanks @zhengchenyu for pointing this out.
   
   This is an oversight. When OFS was implemented, Kerberos principal name (`getUserName()`) are actually used intentionally.
   (For temp bucket names, to avoid any invalid characters in the user name, a [hash](https://github.com/apache/ozone/blob/4128813ab495dfd3941c0252e61e41ca7d1cf1ce/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OFSPath.java#L283) of the user name is used instead.)
   
   For the use case (different machines have different Kerberos principals but maps to the same short name), I agree that short name should be used instead of Kerberos principal.
   
   I'm +1 on this. This also raises other questions that all other calls to `getUserName()` needs to be checked to avoid the same problem.
   
   CC @xiaoyuyao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org