You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2021/02/10 20:49:46 UTC
[kudu-CR] WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17056
Change subject: WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Upgrade gmock/gtest from 1.8.0 to latest stable 1.10.0 release
mainly to allow explicitly skipping tests using GTEST_SKIP()
macro. Includes bunch of other enhancements as well:
https://github.com/google/googletest/releases/tag/release-1.10.0
Earlier we were simply using gtest headers and not linking
gtest library. With the upgrade, kudu build fails with gtest
linker errors and hence building googletest(gtest) as well.
Why WIP?
- Building the gmock/gtest in Debug mode names the library as
libgmockd/libgtestd instead of the expected libgmock/libgtest.
Though we could possibly update cmake modules to use the
explicitly debug named libraries or simply rename when copying
to installed directories. Do we really need gmock/gtest with
debug symbols?
- Updated FindGTest cmake module following pattern from other
other modules. Existing one wasn't used and had bunch of code
which doesn't seem necessary. No cmake expert here, open to
other ideas.
- Haven't figured whether gmock and gtest both need to be linked
in all places where currently gmock was specified. Currently
simply added gtest wherever gmock was specified. It's possible
in some cases one is needed, in some cases other or both.
- Clean up comments and function name where only gmock is used.
- Tested on Ubuntu 18.04 and va1022 RHEL7, need to test on Mac OS.
Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
---
M CMakeLists.txt
M cmake_modules/FindGMock.cmake
M cmake_modules/FindGTest.cmake
M src/kudu/client/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
8 files changed, 38 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/17056/1
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 6
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17056
to look at the new patch set (#2).
Change subject: WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Upgrade gmock/gtest from 1.8.0 to latest stable 1.10.0 release
mainly to allow explicitly skipping tests using GTEST_SKIP()
macro. Includes bunch of other enhancements as well:
https://github.com/google/googletest/releases/tag/release-1.10.0
Earlier we were simply using gtest headers and not linking
gtest library. With the upgrade, kudu build fails with gtest
linker errors and hence building and linking gtest as well.
As per the gtest upgrade notes _TEST_CASE has been deprecated
in favor of _TEST_SUITE and hence replaced the usage accordingly
otherwise deprecation warnings are spewed on Mac OS build.
Why WIP?
- Building the gmock/gtest in Debug mode names the library as
libgmockd/libgtestd instead of the expected libgmock/libgtest.
Though we could possibly update cmake modules to use the
explicitly debug named libraries or simply rename when copying
to installed directories. Do we really need gmock/gtest with
debug symbols?
- Haven't figured whether gmock and gtest both need to be linked
in all places where currently gmock was specified. Currently
simply added gtest wherever gmock was specified. It's possible
in some cases one is needed, in some cases other or both.
Tests:
- Verified debug build on Ubuntu 18.04, va1022 RHEL7 and
Mac OS 10.15.7
Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
---
M CMakeLists.txt
M cmake_modules/FindGMock.cmake
M cmake_modules/FindGTest.cmake
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/CMakeLists.txt
M src/kudu/consensus/log-test.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/authz_token-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/stop_tablet-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/periodic-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/crypto-test.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/async_util-test.cc
M src/kudu/util/atomic-test.cc
M src/kudu/util/cache-bench.cc
M src/kudu/util/cache-test.cc
M src/kudu/util/debug-util-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/file_cache-test.cc
M src/kudu/util/minidump-test.cc
M src/kudu/util/once-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/random_util-test.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/rw_mutex-test.cc
M src/kudu/util/test_macros.h
M src/kudu/util/threadpool-test.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/vars.sh
99 files changed, 323 insertions(+), 355 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/17056/2
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has removed a vote on this change.
Change subject: WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17056
to look at the new patch set (#5).
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
[thirdparty] Upgrade gmock/gtest to 1.10.0
Upgrade gmock/gtest from 1.8.0 to latest stable 1.10.0 release
mainly to allow explicitly skipping tests using GTEST_SKIP()
macro. Includes bunch of other enhancements as well:
https://github.com/google/googletest/releases/tag/release-1.10.0
Earlier we were simply using gtest headers and not linking
gtest library. With the upgrade, kudu build fails with gtest
linker errors and hence building and linking gtest as well.
As per the gtest upgrade notes _TEST_CASE has been deprecated
in favor of _TEST_SUITE and hence replaced the usage accordingly
otherwise deprecation warnings are spewed on Mac OS build.
Note:
- Building the gmock/gtest in Debug mode names the library as
libgmockd/libgtestd instead of the expected libgmock/libgtest.
Though we could possibly update cmake modules to use the
explicitly debug named libraries or simply rename when copying
to installed directories. Using the default cmake build type
for building gmock/gtest instead of the earlier debug mode.
Tests:
- Verified debug build on Ubuntu 18.04, va1022 RHEL7 and
Mac OS 10.15.7
Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
---
M CMakeLists.txt
M cmake_modules/FindGMock.cmake
M cmake_modules/FindGTest.cmake
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/CMakeLists.txt
M src/kudu/consensus/log-test.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/authz_token-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/stop_tablet-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/periodic-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/crypto-test.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/async_util-test.cc
M src/kudu/util/atomic-test.cc
M src/kudu/util/cache-bench.cc
M src/kudu/util/cache-test.cc
M src/kudu/util/debug-util-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/file_cache-test.cc
M src/kudu/util/minidump-test.cc
M src/kudu/util/once-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/random_util-test.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/rw_mutex-test.cc
M src/kudu/util/test_macros.h
M src/kudu/util/threadpool-test.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/vars.sh
99 files changed, 327 insertions(+), 358 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/17056/5
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 5
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17056
to look at the new patch set (#4).
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
[thirdparty] Upgrade gmock/gtest to 1.10.0
Upgrade gmock/gtest from 1.8.0 to latest stable 1.10.0 release
mainly to allow explicitly skipping tests using GTEST_SKIP()
macro. Includes bunch of other enhancements as well:
https://github.com/google/googletest/releases/tag/release-1.10.0
Earlier we were simply using gtest headers and not linking
gtest library. With the upgrade, kudu build fails with gtest
linker errors and hence building and linking gtest as well.
As per the gtest upgrade notes _TEST_CASE has been deprecated
in favor of _TEST_SUITE and hence replaced the usage accordingly
otherwise deprecation warnings are spewed on Mac OS build.
Note:
- Building the gmock/gtest in Debug mode names the library as
libgmockd/libgtestd instead of the expected libgmock/libgtest.
Though we could possibly update cmake modules to use the
explicitly debug named libraries or simply rename when copying
to installed directories. With the default cmake settings
for gmock/gtest.
Tests:
- Verified debug build on Ubuntu 18.04, va1022 RHEL7 and
Mac OS 10.15.7
Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
---
M CMakeLists.txt
M cmake_modules/FindGMock.cmake
M cmake_modules/FindGTest.cmake
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/CMakeLists.txt
M src/kudu/consensus/log-test.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/authz_token-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/stop_tablet-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/periodic-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/crypto-test.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/async_util-test.cc
M src/kudu/util/atomic-test.cc
M src/kudu/util/cache-bench.cc
M src/kudu/util/cache-test.cc
M src/kudu/util/debug-util-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/file_cache-test.cc
M src/kudu/util/minidump-test.cc
M src/kudu/util/once-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/random_util-test.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/rw_mutex-test.cc
M src/kudu/util/test_macros.h
M src/kudu/util/threadpool-test.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/vars.sh
99 files changed, 327 insertions(+), 358 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/17056/4
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 4
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 1: Verified+1
Unrelated test failure in ASAN build for RollingRestartArgs/RollingRestartITest.TestWorkloads/3
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 22:40:13 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has removed a vote on this change.
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 5
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17056/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17056/1//COMMIT_MSG@16
PS1, Line 16: building
> building and linking
Done
http://gerrit.cloudera.org:8080/#/c/17056/1/cmake_modules/FindGMock.cmake
File cmake_modules/FindGMock.cmake:
http://gerrit.cloudera.org:8080/#/c/17056/1/cmake_modules/FindGMock.cmake@a54
PS1, Line 54:
> Will remove this change.
Done
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 12 Feb 2021 18:41:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17056
to look at the new patch set (#6).
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
[thirdparty] Upgrade gmock/gtest to 1.10.0
Upgrade gmock/gtest from 1.8.0 to latest stable 1.10.0 release
mainly to allow explicitly skipping tests using GTEST_SKIP()
macro. Includes bunch of other enhancements as well:
https://github.com/google/googletest/releases/tag/release-1.10.0
Earlier we were simply using gtest headers and not linking
gtest library. With the upgrade, kudu build fails with gtest
linker errors and hence building and linking gtest as well.
As per the gtest upgrade notes _TEST_CASE has been deprecated
in favor of _TEST_SUITE and hence replaced the usage accordingly
otherwise deprecation warnings are spewed on Mac OS build.
Note:
- Building the gmock/gtest in Debug mode names the library as
libgmockd/libgtestd instead of the expected libgmock/libgtest.
Though we could possibly update cmake modules to use the
explicitly debug named libraries or simply rename when copying
to installed directories. Using the default cmake build type
for building gmock/gtest instead of the earlier debug mode.
Tests:
- Verified debug build on Ubuntu 18.04, va1022 RHEL7 and
Mac OS 10.15.7
Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
---
M CMakeLists.txt
M cmake_modules/FindGMock.cmake
M cmake_modules/FindGTest.cmake
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/CMakeLists.txt
M src/kudu/consensus/log-test.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/authz_token-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/stop_tablet-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/periodic-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/crypto-test.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/async_util-test.cc
M src/kudu/util/atomic-test.cc
M src/kudu/util/cache-bench.cc
M src/kudu/util/cache-test.cc
M src/kudu/util/debug-util-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/file_cache-test.cc
M src/kudu/util/minidump-test.cc
M src/kudu/util/once-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/random_util-test.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/rw_mutex-test.cc
M src/kudu/util/test_macros.h
M src/kudu/util/threadpool-test.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/vars.sh
99 files changed, 371 insertions(+), 396 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/17056/6
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 6
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 5: Verified+1
Unrelated test failure in RELEASE build
ShouldGCWals/ParticipantCopyITest.TestCopyParticipantOps/1
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 5
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 23:19:36 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17056/5/cmake_modules/FindGTest.cmake
File cmake_modules/FindGTest.cmake:
http://gerrit.cloudera.org:8080/#/c/17056/5/cmake_modules/FindGTest.cmake@a51
PS5, Line 51:
:
:
:
:
:
:
nit: would it make sense to leave this in? Or at least keep the note about kudu_test_main? Seems like it could be instructive to people expecting gtest_main who might be confused about the entrypoints (at least, I assume that's why the comment was left there in the first place). Don't feel strongly about it though
http://gerrit.cloudera.org:8080/#/c/17056/5/cmake_modules/FindGTest.cmake@27
PS5, Line 27: # GTest_FOUND, If false, do not try to use gtest.
nit: no longer set?
http://gerrit.cloudera.org:8080/#/c/17056/5/cmake_modules/FindGTest.cmake@32
PS5, Line 32:
nit: for the sake of consistency, let's keep the spacing as it was. Or at least align with the (?
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 5
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Feb 2021 00:24:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17056/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17056/1//COMMIT_MSG@16
PS1, Line 16: building
building and linking
http://gerrit.cloudera.org:8080/#/c/17056/1/cmake_modules/FindGMock.cmake
File cmake_modules/FindGMock.cmake:
http://gerrit.cloudera.org:8080/#/c/17056/1/cmake_modules/FindGMock.cmake@a54
PS1, Line 54:
Will remove this change.
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 20:52:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17056/5/src/kudu/client/predicate-test.cc
File src/kudu/client/predicate-test.cc:
http://gerrit.cloudera.org:8080/#/c/17056/5/src/kudu/client/predicate-test.cc@1530
PS5, Line 1530:
nit here and elsewhere: alight this to the parenthesis?
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 5
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Feb 2021 01:01:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/17056/5/cmake_modules/FindGTest.cmake
File cmake_modules/FindGTest.cmake:
http://gerrit.cloudera.org:8080/#/c/17056/5/cmake_modules/FindGTest.cmake@a51
PS5, Line 51:
:
:
:
:
:
:
> nit: would it make sense to leave this in? Or at least keep the note about
Added the commented out code back.
http://gerrit.cloudera.org:8080/#/c/17056/5/cmake_modules/FindGTest.cmake@27
PS5, Line 27: # GTest_FOUND, If false, do not try to use gtest.
> nit: no longer set?
This is set by the find_package_handle_standard_args() function below.
https://cmake.org/cmake/help/latest/module/FindPackageHandleStandardArgs.html
http://gerrit.cloudera.org:8080/#/c/17056/5/cmake_modules/FindGTest.cmake@32
PS5, Line 32:
> nit: for the sake of consistency, let's keep the spacing as it was. Or at l
Rest of the cmake modules use indent of 2 spaces of next line, so I'll change it that ways to be consistent.
http://gerrit.cloudera.org:8080/#/c/17056/5/src/kudu/client/predicate-test.cc
File src/kudu/client/predicate-test.cc:
http://gerrit.cloudera.org:8080/#/c/17056/5/src/kudu/client/predicate-test.cc@1530
PS5, Line 1530:
> nit here and elsewhere: alight this to the parenthesis?
Done
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 5
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Feb 2021 00:10:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
[thirdparty] Upgrade gmock/gtest to 1.10.0
Upgrade gmock/gtest from 1.8.0 to latest stable 1.10.0 release
mainly to allow explicitly skipping tests using GTEST_SKIP()
macro. Includes bunch of other enhancements as well:
https://github.com/google/googletest/releases/tag/release-1.10.0
Earlier we were simply using gtest headers and not linking
gtest library. With the upgrade, kudu build fails with gtest
linker errors and hence building and linking gtest as well.
As per the gtest upgrade notes _TEST_CASE has been deprecated
in favor of _TEST_SUITE and hence replaced the usage accordingly
otherwise deprecation warnings are spewed on Mac OS build.
Note:
- Building the gmock/gtest in Debug mode names the library as
libgmockd/libgtestd instead of the expected libgmock/libgtest.
Though we could possibly update cmake modules to use the
explicitly debug named libraries or simply rename when copying
to installed directories. Using the default cmake build type
for building gmock/gtest instead of the earlier debug mode.
Tests:
- Verified debug build on Ubuntu 18.04, va1022 RHEL7 and
Mac OS 10.15.7
Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Reviewed-on: http://gerrit.cloudera.org:8080/17056
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M CMakeLists.txt
M cmake_modules/FindGMock.cmake
M cmake_modules/FindGTest.cmake
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/CMakeLists.txt
M src/kudu/consensus/log-test.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/authz_token-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/stop_tablet-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/periodic-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/crypto-test.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/async_util-test.cc
M src/kudu/util/atomic-test.cc
M src/kudu/util/cache-bench.cc
M src/kudu/util/cache-test.cc
M src/kudu/util/debug-util-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/file_cache-test.cc
M src/kudu/util/minidump-test.cc
M src/kudu/util/once-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/random_util-test.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/rw_mutex-test.cc
M src/kudu/util/test_macros.h
M src/kudu/util/threadpool-test.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/vars.sh
99 files changed, 371 insertions(+), 396 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 7
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 6: Verified+1
unrelated test failure in CatalogManagerTskITest.LeadershipChangeOnTskGeneration
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 6
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Feb 2021 05:45:43 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 5
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Feb 2021 01:01:52 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17056
to look at the new patch set (#3).
Change subject: WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
WIP [thirdparty] Upgrade gmock/gtest to 1.10.0
Upgrade gmock/gtest from 1.8.0 to latest stable 1.10.0 release
mainly to allow explicitly skipping tests using GTEST_SKIP()
macro. Includes bunch of other enhancements as well:
https://github.com/google/googletest/releases/tag/release-1.10.0
Earlier we were simply using gtest headers and not linking
gtest library. With the upgrade, kudu build fails with gtest
linker errors and hence building and linking gtest as well.
As per the gtest upgrade notes _TEST_CASE has been deprecated
in favor of _TEST_SUITE and hence replaced the usage accordingly
otherwise deprecation warnings are spewed on Mac OS build.
Why WIP?
- Building the gmock/gtest in Debug mode names the library as
libgmockd/libgtestd instead of the expected libgmock/libgtest.
Though we could possibly update cmake modules to use the
explicitly debug named libraries or simply rename when copying
to installed directories. Do we really need gmock/gtest with
debug symbols?
- Haven't figured whether gmock and gtest both need to be linked
in all places where currently gmock was specified. Currently
simply added gtest wherever gmock was specified. It's possible
in some cases one is needed, in some cases other or both.
Tests:
- Verified debug build on Ubuntu 18.04, va1022 RHEL7 and
Mac OS 10.15.7
Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
---
M CMakeLists.txt
M cmake_modules/FindGMock.cmake
M cmake_modules/FindGTest.cmake
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/CMakeLists.txt
M src/kudu/consensus/log-test.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/authz_token-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/stop_tablet-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/periodic-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/crypto-test.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/async_util-test.cc
M src/kudu/util/atomic-test.cc
M src/kudu/util/cache-bench.cc
M src/kudu/util/cache-test.cc
M src/kudu/util/debug-util-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/file_cache-test.cc
M src/kudu/util/minidump-test.cc
M src/kudu/util/once-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/random_util-test.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/rw_mutex-test.cc
M src/kudu/util/test_macros.h
M src/kudu/util/threadpool-test.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/vars.sh
99 files changed, 323 insertions(+), 355 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/17056/3
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 )
Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7f5c11bef29a0d428d8d55d70ebdf888c6f645
Gerrit-Change-Number: 17056
Gerrit-PatchSet: 6
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Feb 2021 05:45:58 +0000
Gerrit-HasComments: No