You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by abhinav roy <ab...@citrix.com> on 2014/08/21 10:13:46 UTC
Re: Review Request 24420: vGPU Test Automation ( Check for vGPU
resources & VM lifecycle tests)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/
-----------------------------------------------------------
(Updated Aug. 21, 2014, 8:13 a.m.)
Review request for cloudstack, Doug Clark, sailaja mada, and Sanjay Tripathi.
Summary (updated)
-----------------
vGPU Test Automation ( Check for vGPU resources & VM lifecycle tests)
Repository: cloudstack-git
Description (updated)
-------
This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU resources present in a vGPU VM deployed on CS. It has the following tests :
1. A function to validate vGPU resources in a VM. It does validation on both the host as well as on CS.
It includes following lifecycle tests.
2. Deploy VM
3. Stop VM
4. Start VM
5. Restore VM
6. Reboot VM
7. Destroy VM
8. Recover VM
NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review with Doug. We decided to include those tests here just to remove the overhead of registering template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/
Diffs (updated)
-----
test/integration/component/test_deploy_vgpu_vm.py fd3f374
Diff: https://reviews.apache.org/r/24420/diff/
Testing (updated)
-------
Testing :
1. Executed the script on non GPU test setup and ensured tests being skipped.
2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are working fine and the function is checking for the vGPU resources in a vGPU VM.
Thanks,
abhinav roy
Re: Review Request 24420: vGPU Test Automation ( Check for vGPU
resources & VM lifecycle tests)
Posted by sailaja mada <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/#review51988
-----------------------------------------------------------
Commited the changes @
Repository: cloudstack
Updated Branches:
refs/heads/master e16ab59c5 -> 615c070c0
vgpu lifecycle test cases with review comments
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/615c070c
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/615c070c
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/615c070c
Branch: refs/heads/master
Commit: 615c070c0a1b86c00b7b878ac32a183bcd8b1ab1
Parents: e16ab59
Author: Abhinav Roy <ab...@citrix.com>
Authored: Thu Aug 21 13:24:54 2014 +0530
Committer: sailajamada <sa...@citrix.com>
Committed: Mon Sep 1 14:13:39 2014 +0530
----------------------------------------------------------------------
.../component/test_deploy_vgpu_vm.py | 321 +++++++++++++++----
1 file changed, 264 insertions(+), 57 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/615c070c/test/integration/component/test_deploy_vgpu_vm.py
- sailaja mada
On Aug. 22, 2014, 2:09 p.m., abhinav roy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24420/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 2:09 p.m.)
>
>
> Review request for cloudstack, Doug Clark, John Dilley, sailaja mada, and Sanjay Tripathi.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU resources present in a vGPU VM deployed on CS. It has the following tests :
>
> 1. A function to validate vGPU resources in a VM. It does validation on both the host as well as on CS.
> It includes following lifecycle tests.
>
>
> 2. Deploy VM
> 3. Stop VM
> 4. Start VM
> 5. Restore VM
> 6. Reboot VM
> 7. Destroy VM
> 8. Recover VM
>
>
> NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review with Doug. We decided to include those tests here just to remove the overhead of registering template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vgpu_vm.py fd3f374
>
> Diff: https://reviews.apache.org/r/24420/diff/
>
>
> Testing
> -------
>
> Testing :
>
> 1. Executed the script on non GPU test setup and ensured tests being skipped.
> 2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are working fine and the function is checking for the vGPU resources in a vGPU VM.
>
>
> Thanks,
>
> abhinav roy
>
>
Re: Review Request 24420: vGPU Test Automation ( Check for vGPU
resources & VM lifecycle tests)
Posted by sailaja mada <sa...@citrix.com>.
> On Aug. 26, 2014, 2:41 p.m., John Dilley wrote:
> > Ship It!
Repository: cloudstack
Updated Branches:
refs/heads/master e16ab59c5 -> 615c070c0
vgpu lifecycle test cases with review comments
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/615c070c
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/615c070c
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/615c070c
Branch: refs/heads/master
Commit: 615c070c0a1b86c00b7b878ac32a183bcd8b1ab1
Parents: e16ab59
Author: Abhinav Roy <ab...@citrix.com>
Authored: Thu Aug 21 13:24:54 2014 +0530
Committer: sailajamada <sa...@citrix.com>
Committed: Mon Sep 1 14:13:39 2014 +0530
----------------------------------------------------------------------
.../component/test_deploy_vgpu_vm.py | 321 +++++++++++++++----
1 file changed, 264 insertions(+), 57 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/615c070c/test/integration/component/test_deploy_vgpu_vm.py
- sailaja
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/#review51527
-----------------------------------------------------------
On Aug. 22, 2014, 2:09 p.m., abhinav roy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24420/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 2:09 p.m.)
>
>
> Review request for cloudstack, Doug Clark, John Dilley, sailaja mada, and Sanjay Tripathi.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU resources present in a vGPU VM deployed on CS. It has the following tests :
>
> 1. A function to validate vGPU resources in a VM. It does validation on both the host as well as on CS.
> It includes following lifecycle tests.
>
>
> 2. Deploy VM
> 3. Stop VM
> 4. Start VM
> 5. Restore VM
> 6. Reboot VM
> 7. Destroy VM
> 8. Recover VM
>
>
> NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review with Doug. We decided to include those tests here just to remove the overhead of registering template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vgpu_vm.py fd3f374
>
> Diff: https://reviews.apache.org/r/24420/diff/
>
>
> Testing
> -------
>
> Testing :
>
> 1. Executed the script on non GPU test setup and ensured tests being skipped.
> 2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are working fine and the function is checking for the vGPU resources in a vGPU VM.
>
>
> Thanks,
>
> abhinav roy
>
>
Re: Review Request 24420: vGPU Test Automation ( Check for vGPU
resources & VM lifecycle tests)
Posted by John Dilley <jo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/#review51527
-----------------------------------------------------------
Ship it!
Ship It!
- John Dilley
On Aug. 22, 2014, 2:09 p.m., abhinav roy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24420/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 2:09 p.m.)
>
>
> Review request for cloudstack, Doug Clark, John Dilley, sailaja mada, and Sanjay Tripathi.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU resources present in a vGPU VM deployed on CS. It has the following tests :
>
> 1. A function to validate vGPU resources in a VM. It does validation on both the host as well as on CS.
> It includes following lifecycle tests.
>
>
> 2. Deploy VM
> 3. Stop VM
> 4. Start VM
> 5. Restore VM
> 6. Reboot VM
> 7. Destroy VM
> 8. Recover VM
>
>
> NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review with Doug. We decided to include those tests here just to remove the overhead of registering template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vgpu_vm.py fd3f374
>
> Diff: https://reviews.apache.org/r/24420/diff/
>
>
> Testing
> -------
>
> Testing :
>
> 1. Executed the script on non GPU test setup and ensured tests being skipped.
> 2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are working fine and the function is checking for the vGPU resources in a vGPU VM.
>
>
> Thanks,
>
> abhinav roy
>
>
Re: Review Request 24420: vGPU Test Automation ( Check for vGPU
resources & VM lifecycle tests)
Posted by abhinav roy <ab...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 2:09 p.m.)
Review request for cloudstack, Doug Clark, John Dilley, sailaja mada, and Sanjay Tripathi.
Repository: cloudstack-git
Description
-------
This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU resources present in a vGPU VM deployed on CS. It has the following tests :
1. A function to validate vGPU resources in a VM. It does validation on both the host as well as on CS.
It includes following lifecycle tests.
2. Deploy VM
3. Stop VM
4. Start VM
5. Restore VM
6. Reboot VM
7. Destroy VM
8. Recover VM
NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review with Doug. We decided to include those tests here just to remove the overhead of registering template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/
Diffs (updated)
-----
test/integration/component/test_deploy_vgpu_vm.py fd3f374
Diff: https://reviews.apache.org/r/24420/diff/
Testing
-------
Testing :
1. Executed the script on non GPU test setup and ensured tests being skipped.
2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are working fine and the function is checking for the vGPU resources in a vGPU VM.
Thanks,
abhinav roy
Re: Review Request 24420: vGPU Test Automation ( Check for vGPU
resources & VM lifecycle tests)
Posted by abhinav roy <ab...@citrix.com>.
> On Aug. 22, 2014, 9:20 a.m., John Dilley wrote:
> >
All the review comments are incorporated excpet one which was getting the pciDevice value from the host. I have given my reasons below.
Also, one more change was made. In the function "check_for_vGPU_resource" now we are passing the hostid of the VM also, reason being :
Previously we were doing ssh to the last host in the list we get in setup class which may not be the host on which vm is deployed or it maybe in a different cluster than the VM.
So, now we are creating a ssh connection with the host on which VM is deployed from inside this function so that we get the right information we need.
> On Aug. 22, 2014, 9:20 a.m., John Dilley wrote:
> > test/integration/component/test_deploy_vgpu_vm.py, line 190
> > <https://reviews.apache.org/r/24420/diff/5/?file=665972#file665972line190>
> >
> > Don't hardcode "Group of NVIDIA Corporation GK104GL [GRID K1] GPUs" into the test, run gpu-group-list on the host instead
I think we can stick with this because CS itself hardcodes the pciDevice. When we try to create a service offering from CCP UI, we don't pass the pciDevice, we just pass the card type.
If we pass NVIDIA GRID K2, it itslef picks up the pciDevice as "Group of NVIDIA Corporation GK104GL [GRID K2] GPUs"
If we pass NVIDIA GRID K1, it picks "Group of NVIDIA Corporation GK107GL [GRID K1] GPUs"
So, if the host has pciDevice value anything other than this then the VM deployment will fail by itself.
Thats why i think we can ignore this in here.
> On Aug. 22, 2014, 9:20 a.m., John Dilley wrote:
> > test/integration/component/test_deploy_vgpu_vm.py, line 215
> > <https://reviews.apache.org/r/24420/diff/5/?file=665972#file665972line215>
> >
> > Don't hardcode "Group of NVIDIA Corporation GK104GL [GRID K2] GPUs" into the test, run gpu-group-list on the host instead
I think we can stick with this because CS itself hardcodes the pciDevice. When we try to create a service offering from CCP UI, we don't pass the pciDevice, we just pass the card type.
If we pass NVIDIA GRID K2, it itslef picks up the pciDevice as "Group of NVIDIA Corporation GK104GL [GRID K2] GPUs"
If we pass NVIDIA GRID K1, it picks "Group of NVIDIA Corporation GK107GL [GRID K1] GPUs"
So, if the host has pciDevice value anything other than this then the VM deployment will fail by itself.
Thats why i think we can ignore this in here.
- abhinav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/#review51272
-----------------------------------------------------------
On Aug. 22, 2014, 2:09 p.m., abhinav roy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24420/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 2:09 p.m.)
>
>
> Review request for cloudstack, Doug Clark, John Dilley, sailaja mada, and Sanjay Tripathi.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU resources present in a vGPU VM deployed on CS. It has the following tests :
>
> 1. A function to validate vGPU resources in a VM. It does validation on both the host as well as on CS.
> It includes following lifecycle tests.
>
>
> 2. Deploy VM
> 3. Stop VM
> 4. Start VM
> 5. Restore VM
> 6. Reboot VM
> 7. Destroy VM
> 8. Recover VM
>
>
> NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review with Doug. We decided to include those tests here just to remove the overhead of registering template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vgpu_vm.py fd3f374
>
> Diff: https://reviews.apache.org/r/24420/diff/
>
>
> Testing
> -------
>
> Testing :
>
> 1. Executed the script on non GPU test setup and ensured tests being skipped.
> 2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are working fine and the function is checking for the vGPU resources in a vGPU VM.
>
>
> Thanks,
>
> abhinav roy
>
>
Re: Review Request 24420: vGPU Test Automation ( Check for vGPU
resources & VM lifecycle tests)
Posted by John Dilley <jo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/#review51272
-----------------------------------------------------------
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89415>
Why while rather than if?
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89417>
Turn while into if above, get rid of this if, and put the following line under "if k1hosts != 0" above
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89420>
Don't hardcode "Group of NVIDIA Corporation GK104GL [GRID K1] GPUs" into the test, run gpu-group-list on the host instead
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89418>
Same comment as above
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89419>
Same comment as above
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89416>
Don't hardcode "Group of NVIDIA Corporation GK104GL [GRID K2] GPUs" into the test, run gpu-group-list on the host instead
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89421>
use "xe vgpu-list vm-name-label=<vminstancename> params=<param name> --minimal", then you can get rid of most of the subsequent lines
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89422>
In particular, relying on the type parameter being in position 8 is likely to be fragile - XenServer doesn't guarentee the order of the parameters. Future versions could add a parameter and break this
test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89423>
Give the test a different name, because it doesn't actually deploy a VM.
- John Dilley
On Aug. 21, 2014, 12:33 p.m., abhinav roy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24420/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 12:33 p.m.)
>
>
> Review request for cloudstack, Doug Clark, sailaja mada, and Sanjay Tripathi.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU resources present in a vGPU VM deployed on CS. It has the following tests :
>
> 1. A function to validate vGPU resources in a VM. It does validation on both the host as well as on CS.
> It includes following lifecycle tests.
>
>
> 2. Deploy VM
> 3. Stop VM
> 4. Start VM
> 5. Restore VM
> 6. Reboot VM
> 7. Destroy VM
> 8. Recover VM
>
>
> NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review with Doug. We decided to include those tests here just to remove the overhead of registering template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vgpu_vm.py fd3f374
>
> Diff: https://reviews.apache.org/r/24420/diff/
>
>
> Testing
> -------
>
> Testing :
>
> 1. Executed the script on non GPU test setup and ensured tests being skipped.
> 2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are working fine and the function is checking for the vGPU resources in a vGPU VM.
>
>
> Thanks,
>
> abhinav roy
>
>
Re: Review Request 24420: vGPU Test Automation ( Check for vGPU
resources & VM lifecycle tests)
Posted by abhinav roy <ab...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/
-----------------------------------------------------------
(Updated Aug. 21, 2014, 12:33 p.m.)
Review request for cloudstack, Doug Clark, sailaja mada, and Sanjay Tripathi.
Repository: cloudstack-git
Description
-------
This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU resources present in a vGPU VM deployed on CS. It has the following tests :
1. A function to validate vGPU resources in a VM. It does validation on both the host as well as on CS.
It includes following lifecycle tests.
2. Deploy VM
3. Stop VM
4. Start VM
5. Restore VM
6. Reboot VM
7. Destroy VM
8. Recover VM
NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review with Doug. We decided to include those tests here just to remove the overhead of registering template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/
Diffs (updated)
-----
test/integration/component/test_deploy_vgpu_vm.py fd3f374
Diff: https://reviews.apache.org/r/24420/diff/
Testing
-------
Testing :
1. Executed the script on non GPU test setup and ensured tests being skipped.
2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are working fine and the function is checking for the vGPU resources in a vGPU VM.
Thanks,
abhinav roy