You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/02/23 20:54:48 UTC
Review Request 31314: After cluster install one host doesn't have any
stack version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
Bugs: AMBARI-9755
https://issues.apache.org/jira/browse/AMBARI-9755
Repository: ambari
Description
-------
* When marking a cluster version as CURRENT, take into account hosts that don't advertise version and add a host_version record.
* Fixed error in a ZK import.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java c609b0a
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 92465a0
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 8865b26
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3
Diff: https://reviews.apache.org/r/31314/diff/
Testing
-------
Pending
Thanks,
Nate Cole
Re: Review Request 31314: After cluster install one host doesn't have
any stack version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/#review73653
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 23, 2015, 7:55 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31314/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 7:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-9755
> https://issues.apache.org/jira/browse/AMBARI-9755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * When marking a cluster version as CURRENT, take into account hosts that don't advertise version and add a host_version record.
> * Fixed error in a ZK import.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java c609b0a
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 92465a0
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 8865b26
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3
>
> Diff: https://reviews.apache.org/r/31314/diff/
>
>
> Testing
> -------
>
> Manual testing on new and upgrading cluster. Automated testing pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31314: After cluster install one host doesn't have
any stack version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/#review73689
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 23, 2015, 10:19 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31314/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 10:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-9755
> https://issues.apache.org/jira/browse/AMBARI-9755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * When marking a cluster version as CURRENT, take into account hosts that don't advertise version and add a host_version record.
> * Fixed error in a ZK import.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java c609b0a
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 92465a0
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 8865b26
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3
>
> Diff: https://reviews.apache.org/r/31314/diff/
>
>
> Testing
> -------
>
> Manual testing on new and upgrading cluster. Automated testing pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31314: After cluster install one host doesn't have
any stack version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/
-----------------------------------------------------------
(Updated Feb. 23, 2015, 5:19 p.m.)
Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
Changes
-------
Addressed comments. Testing pending. After discussion with Alejandro, mark only CURRENT records with INSTALLED, and either change any current record (for downgrade scenario) or make a new one if not found.
Bugs: AMBARI-9755
https://issues.apache.org/jira/browse/AMBARI-9755
Repository: ambari
Description
-------
* When marking a cluster version as CURRENT, take into account hosts that don't advertise version and add a host_version record.
* Fixed error in a ZK import.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java c609b0a
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 92465a0
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 8865b26
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3
Diff: https://reviews.apache.org/r/31314/diff/
Testing
-------
Manual testing on new and upgrading cluster. Automated testing pending.
Thanks,
Nate Cole
Re: Review Request 31314: After cluster install one host doesn't have
any stack version
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 23, 2015, 3:08 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, line 1526
> > <https://reviews.apache.org/r/31314/diff/1/?file=873070#file873070line1526>
> >
> > This may transition other host versions from INSTALL_FAILED to INSTALLED. I believe we don't need the else block here.
Please contact me about this. I'm open to suggestions - but I thought we couldn't have two host_versions marked CURRENT at the same time. So where can we get the value for the one that's not current? Remember - this is for hosts that have no reportable versions, so it may be hard for anything other than INSTALLED or CURRENT.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/#review73651
-----------------------------------------------------------
On Feb. 23, 2015, 2:55 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31314/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 2:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-9755
> https://issues.apache.org/jira/browse/AMBARI-9755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * When marking a cluster version as CURRENT, take into account hosts that don't advertise version and add a host_version record.
> * Fixed error in a ZK import.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java c609b0a
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 92465a0
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 8865b26
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3
>
> Diff: https://reviews.apache.org/r/31314/diff/
>
>
> Testing
> -------
>
> Manual testing on new and upgrading cluster. Automated testing pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31314: After cluster install one host doesn't have
any stack version
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 23, 2015, 3:08 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, line 1553
> > <https://reviews.apache.org/r/31314/diff/1/?file=873070#file873070line1553>
> >
> > There's a class called ServiceComponentHostSummary with the method haveAllComponentsFinishedAdvertisingVersion() that can be used instead.
That's not quite enough though, because that method would return true when there is NOTHING advertising version, and that's not what I want to check.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/#review73651
-----------------------------------------------------------
On Feb. 23, 2015, 2:55 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31314/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 2:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-9755
> https://issues.apache.org/jira/browse/AMBARI-9755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * When marking a cluster version as CURRENT, take into account hosts that don't advertise version and add a host_version record.
> * Fixed error in a ZK import.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java c609b0a
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 92465a0
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 8865b26
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3
>
> Diff: https://reviews.apache.org/r/31314/diff/
>
>
> Testing
> -------
>
> Manual testing on new and upgrading cluster. Automated testing pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31314: After cluster install one host doesn't have
any stack version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/#review73651
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
<https://reviews.apache.org/r/31314/#comment120050>
This may transition other host versions from INSTALL_FAILED to INSTALLED. I believe we don't need the else block here.
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
<https://reviews.apache.org/r/31314/#comment120052>
There's a class called ServiceComponentHostSummary with the method haveAllComponentsFinishedAdvertisingVersion() that can be used instead.
- Alejandro Fernandez
On Feb. 23, 2015, 7:55 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31314/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 7:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-9755
> https://issues.apache.org/jira/browse/AMBARI-9755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * When marking a cluster version as CURRENT, take into account hosts that don't advertise version and add a host_version record.
> * Fixed error in a ZK import.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java c609b0a
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 92465a0
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 8865b26
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3
>
> Diff: https://reviews.apache.org/r/31314/diff/
>
>
> Testing
> -------
>
> Manual testing on new and upgrading cluster. Automated testing pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31314: After cluster install one host doesn't have
any stack version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/
-----------------------------------------------------------
(Updated Feb. 23, 2015, 2:55 p.m.)
Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
Bugs: AMBARI-9755
https://issues.apache.org/jira/browse/AMBARI-9755
Repository: ambari
Description
-------
* When marking a cluster version as CURRENT, take into account hosts that don't advertise version and add a host_version record.
* Fixed error in a ZK import.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java c609b0a
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 92465a0
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 8865b26
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3
Diff: https://reviews.apache.org/r/31314/diff/
Testing (updated)
-------
Manual testing on new and upgrading cluster. Automated testing pending.
Thanks,
Nate Cole