[GitHub] [pulsar] codelipenghui commented on a diff in pull request #18390: [fix][broker] fix bug caused by optimistic locking

["codelipenghui (via GitHub)" <gi...@apache.org>]

codelipenghui commented on code in PR #18390:
URL: https://github.com/apache/pulsar/pull/18390#discussion_r1322969520


##########
pulsar-common/src/test/java/org/apache/pulsar/common/util/collections/ConcurrentLongHashMapTest.java:
##########
@@ -213,6 +214,66 @@ public void testExpandShrinkAndClear() {
         assertTrue(map.capacity() == initCapacity);
     }
 
+    @Test

Review Comment:
   ```suggestion
       @Test(invocationCount = 10)
   ```
   
   It's better to add `invocationCount` to avoid regression because even if new changes breaks the behavior, the test might also get passed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org