You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by xu...@apache.org on 2018/11/21 10:32:36 UTC
carbondata git commit: [HOTFIX] Improve log message in
CarbonWriterBuilder
Repository: carbondata
Updated Branches:
refs/heads/master c2ae98744 -> 3b8de320d
[HOTFIX] Improve log message in CarbonWriterBuilder
In master the log message is not proper:
AppName is not set, please use writtenBy() API to set the App Namewhich is using SDK
This closes #2920
Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/3b8de320
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/3b8de320
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/3b8de320
Branch: refs/heads/master
Commit: 3b8de320d7092470e6d58ad3dcee594e3ae7ecc8
Parents: c2ae987
Author: Jacky Li <ja...@huawei.com>
Authored: Wed Nov 14 20:54:33 2018 +0800
Committer: xuchuanyin <xu...@hust.edu.cn>
Committed: Wed Nov 21 18:32:26 2018 +0800
----------------------------------------------------------------------
.../org/apache/carbondata/sdk/file/CarbonWriterBuilder.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/carbondata/blob/3b8de320/store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
----------------------------------------------------------------------
diff --git a/store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java b/store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
index 917d4dc..1ca5b74 100644
--- a/store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
+++ b/store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
@@ -438,13 +438,13 @@ public class CarbonWriterBuilder {
Objects.requireNonNull(path, "path should not be null");
if (this.writerType == null) {
throw new IOException(
- "Writer type is not set, use withCsvInput() or withAvroInput() or withJsonInput() "
+ "'writerType' must be set, use withCsvInput() or withAvroInput() or withJsonInput() "
+ "API based on input");
}
if (this.writtenByApp == null || this.writtenByApp.isEmpty()) {
throw new RuntimeException(
- "AppName is not set, please use writtenBy() API to set the App Name"
- + "which is using SDK");
+ "'writtenBy' must be set when writing carbon files, use writtenBy() API to "
+ + "set it, it can be the name of the application which is using the SDK");
}
CarbonLoadModel loadModel = buildLoadModel(schema);
loadModel.setSdkWriterCores(numOfThreads);