You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/20 06:55:15 UTC

[GitHub] [pulsar] RobertIndie opened a new issue, #18131: Add CI for checking code style of pulsar connectors

RobertIndie opened a new issue, #18131:
URL: https://github.com/apache/pulsar/issues/18131

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   Recently, there has been a checkstyle issue in the jdbc connector core. It seems that there is no CI to check the code style of these modules. Need to make this check happen in the CI.
   
   ### Solution
   
   _No response_
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #18131: Add CI for checking code style of pulsar connectors

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #18131:
URL: https://github.com/apache/pulsar/issues/18131#issuecomment-1286315703

   @RobertIndie I'm opening a PR #18142 against this issue. But it's highly possible that we have some remaining violence to fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi closed issue #18131: Add CI for checking code style of pulsar connectors

Posted by GitBox <gi...@apache.org>.
nicoloboschi closed issue #18131: Add CI for checking code style of pulsar connectors
URL: https://github.com/apache/pulsar/issues/18131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #18131: Add CI for checking code style of pulsar connectors

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #18131:
URL: https://github.com/apache/pulsar/issues/18131#issuecomment-1286314051

   Agree. I think...wait a minute, IIRC we have a checkstyle goal here previously:
   
   https://github.com/apache/pulsar/blob/0c326c0845eb66f513a5f199308620074cdb9b04/.github/workflows/pulsar-ci.yaml#L106-L107
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org