You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "Rob Vesse (Created) (JIRA)" <ji...@apache.org> on 2012/01/31 22:29:58 UTC

[jira] [Created] (JENA-207) FmtUtils.stringForNode() does not escape tab characters

FmtUtils.stringForNode() does not escape tab characters
-------------------------------------------------------

                 Key: JENA-207
                 URL: https://issues.apache.org/jira/browse/JENA-207
             Project: Jena
          Issue Type: Bug
          Components: ARQ
    Affects Versions: ARQ 2.9.0
            Reporter: Rob Vesse
             Fix For: ARQ 2.9.1
         Attachments: FmtUtilsTabEscaping.patch

FmtUtils.stringForNode() delegates literal formatting to FmtUtils.stringForLiteral() which delegates string escaping to stringEsc()

The issue is that the whitespace escaping section has code to deal with escaping tab characters but has a logical flaw which means tab characters won't hit that code path, the if statement surrounding the white space escapes section checks for the other kinds of whitespace characters but not for tab

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (JENA-207) FmtUtils.stringForNode() does not escape tab characters

Posted by "Andy Seaborne (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JENA-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Seaborne closed JENA-207.
------------------------------

    
> FmtUtils.stringForNode() does not escape tab characters
> -------------------------------------------------------
>
>                 Key: JENA-207
>                 URL: https://issues.apache.org/jira/browse/JENA-207
>             Project: Jena
>          Issue Type: Bug
>          Components: ARQ
>    Affects Versions: ARQ 2.9.0
>            Reporter: Rob Vesse
>            Assignee: Andy Seaborne
>             Fix For: ARQ 2.9.1
>
>         Attachments: FmtUtilsTabEscaping.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> FmtUtils.stringForNode() delegates literal formatting to FmtUtils.stringForLiteral() which delegates string escaping to stringEsc()
> The issue is that the whitespace escaping section has code to deal with escaping tab characters but has a logical flaw which means tab characters won't hit that code path, the if statement surrounding the white space escapes section checks for the other kinds of whitespace characters but not for tab

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JENA-207) FmtUtils.stringForNode() does not escape tab characters

Posted by "Rob Vesse (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JENA-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Vesse updated JENA-207:
---------------------------

    Attachment: FmtUtilsTabEscaping.patch

Fix for FmtUtils.stringEsc() so that it actually escapes tab characters

Also includes an additional test for SPARQL TSV output which was how I spotted this bug originally
                
> FmtUtils.stringForNode() does not escape tab characters
> -------------------------------------------------------
>
>                 Key: JENA-207
>                 URL: https://issues.apache.org/jira/browse/JENA-207
>             Project: Jena
>          Issue Type: Bug
>          Components: ARQ
>    Affects Versions: ARQ 2.9.0
>            Reporter: Rob Vesse
>             Fix For: ARQ 2.9.1
>
>         Attachments: FmtUtilsTabEscaping.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> FmtUtils.stringForNode() delegates literal formatting to FmtUtils.stringForLiteral() which delegates string escaping to stringEsc()
> The issue is that the whitespace escaping section has code to deal with escaping tab characters but has a logical flaw which means tab characters won't hit that code path, the if statement surrounding the white space escapes section checks for the other kinds of whitespace characters but not for tab

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (JENA-207) FmtUtils.stringForNode() does not escape tab characters

Posted by "Andy Seaborne (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JENA-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Seaborne resolved JENA-207.
--------------------------------

    Resolution: Fixed
      Assignee: Andy Seaborne

Applied and committed - thanks.
                
> FmtUtils.stringForNode() does not escape tab characters
> -------------------------------------------------------
>
>                 Key: JENA-207
>                 URL: https://issues.apache.org/jira/browse/JENA-207
>             Project: Jena
>          Issue Type: Bug
>          Components: ARQ
>    Affects Versions: ARQ 2.9.0
>            Reporter: Rob Vesse
>            Assignee: Andy Seaborne
>             Fix For: ARQ 2.9.1
>
>         Attachments: FmtUtilsTabEscaping.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> FmtUtils.stringForNode() delegates literal formatting to FmtUtils.stringForLiteral() which delegates string escaping to stringEsc()
> The issue is that the whitespace escaping section has code to deal with escaping tab characters but has a logical flaw which means tab characters won't hit that code path, the if statement surrounding the white space escapes section checks for the other kinds of whitespace characters but not for tab

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira