You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ta...@apache.org on 2022/01/14 06:19:28 UTC
[iotdb] 03/13: add info logs (#4464)
This is an automated email from the ASF dual-hosted git repository.
tanxinyu pushed a commit to branch master_performance
in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit c13635c4663b157ad6da41db44ea5dd22f5bf232
Author: Mrquan <50...@users.noreply.github.com>
AuthorDate: Thu Nov 25 17:26:12 2021 +0800
add info logs (#4464)
Co-authored-by: 权思屹 <si...@gmail.com>
---
server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java | 1 +
.../org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java | 3 +++
.../iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java | 3 +++
.../src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java | 1 +
service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java | 6 ++++++
.../src/main/java/org/apache/iotdb/session/SessionConnection.java | 1 +
6 files changed, 15 insertions(+)
diff --git a/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java b/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
index 4850820..eb9a5ad 100644
--- a/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
+++ b/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
@@ -650,6 +650,7 @@ public class StorageEngine implements IService {
try {
blockInsertionIfReject(null);
} catch (WriteProcessRejectException e) {
+ logger.info("Insert tablet reject");
TSStatus[] results = new TSStatus[insertTabletPlan.getRowCount()];
Arrays.fill(results, RpcUtils.getStatus(TSStatusCode.WRITE_PROCESS_REJECT));
throw new BatchProcessException(results);
diff --git a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
index 0f0d827..a1403ae 100644
--- a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
+++ b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
@@ -291,6 +291,7 @@ public class TsFileProcessor {
}
} catch (WriteProcessException e) {
for (int i = start; i < end; i++) {
+ logger.info("Insert tablet: write_process_reject");
results[i] = RpcUtils.getStatus(TSStatusCode.WRITE_PROCESS_REJECT, e.getMessage());
}
throw new WriteProcessException(e);
@@ -304,6 +305,7 @@ public class TsFileProcessor {
}
} catch (Exception e) {
for (int i = start; i < end; i++) {
+ logger.info("Insert tablet: internal_server_error");
results[i] = RpcUtils.getStatus(TSStatusCode.INTERNAL_SERVER_ERROR, e.getMessage());
}
if (enableMemControl && memIncrements != null) {
@@ -320,6 +322,7 @@ public class TsFileProcessor {
}
} catch (WriteProcessException e) {
for (int i = start; i < end; i++) {
+ logger.info("Insert tablet: internal_server_error");
results[i] = RpcUtils.getStatus(TSStatusCode.INTERNAL_SERVER_ERROR, e.getMessage());
}
throw new WriteProcessException(e);
diff --git a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java
index 0b416cc..826ce6d 100755
--- a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java
+++ b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java
@@ -967,6 +967,7 @@ public class VirtualStorageGroupProcessor {
long currTime = insertTabletPlan.getTimes()[loc];
// skip points that do not satisfy TTL
if (!isAlive(currTime)) {
+ logger.info("Insert tablet out of TTL");
results[loc] =
RpcUtils.getStatus(
TSStatusCode.OUT_OF_TTL_ERROR,
@@ -979,6 +980,7 @@ public class VirtualStorageGroupProcessor {
}
// loc pointing at first legal position
if (loc == insertTabletPlan.getRowCount()) {
+ logger.info("Insert tablet out of TTL of all points");
throw new BatchProcessException(results);
}
@@ -1096,6 +1098,7 @@ public class VirtualStorageGroupProcessor {
TsFileProcessor tsFileProcessor = getOrCreateTsFileProcessor(timePartitionId, sequence);
if (tsFileProcessor == null) {
for (int i = start; i < end; i++) {
+ logger.info("Insert tablet: internal_server_error");
results[i] =
RpcUtils.getStatus(
TSStatusCode.INTERNAL_SERVER_ERROR,
diff --git a/server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java b/server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
index 83e3e1d..aad4cdb 100644
--- a/server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
+++ b/server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
@@ -1652,6 +1652,7 @@ public class PlanExecutor implements IPlanExecutor {
return;
}
try {
+ logger.info("Execute insert tablet {}", insertTabletPlan.getRowCount());
insertTabletPlan.setMeasurementMNodes(
new IMeasurementMNode[insertTabletPlan.getMeasurements().length]);
diff --git a/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java b/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
index 0cfa04b..1cb4ef9 100644
--- a/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
+++ b/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
@@ -25,6 +25,9 @@ import org.apache.iotdb.service.rpc.thrift.TSFetchResultsResp;
import org.apache.iotdb.service.rpc.thrift.TSIService;
import org.apache.iotdb.service.rpc.thrift.TSStatus;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import java.lang.reflect.Proxy;
import java.text.SimpleDateFormat;
import java.time.Instant;
@@ -37,6 +40,7 @@ import java.util.Map;
public class RpcUtils {
+ private static final Logger logger = LoggerFactory.getLogger(RpcUtils.class);
/** How big should the default read and write buffers be? Defaults to 1KB */
public static final int THRIFT_DEFAULT_BUF_CAPACITY = 1024;
/**
@@ -136,11 +140,13 @@ public class RpcUtils {
}
public static void verifySuccess(List<TSStatus> statuses) throws BatchExecutionException {
+ logger.info("Multiple error in executing insert tablet, sub status: {}", statuses.size());
StringBuilder errMsgs = new StringBuilder();
for (TSStatus status : statuses) {
if (status.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()
&& status.getCode() != TSStatusCode.NEED_REDIRECTION.getStatusCode()) {
errMsgs.append(status.getMessage()).append(";");
+ logger.info("error status {} ", status.getCode());
}
}
if (errMsgs.length() > 0) {
diff --git a/session/src/main/java/org/apache/iotdb/session/SessionConnection.java b/session/src/main/java/org/apache/iotdb/session/SessionConnection.java
index b5d479c..f140551 100644
--- a/session/src/main/java/org/apache/iotdb/session/SessionConnection.java
+++ b/session/src/main/java/org/apache/iotdb/session/SessionConnection.java
@@ -564,6 +564,7 @@ public class SessionConnection {
throws IoTDBConnectionException, StatementExecutionException, RedirectException {
request.setSessionId(sessionId);
try {
+ logger.info("Execute insert tablet {}", request.getSize());
RpcUtils.verifySuccessWithRedirection(client.insertTablet(request));
} catch (TException e) {
if (reconnect()) {