You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/03/19 20:16:47 UTC

[GitHub] [hbase] shahrs87 commented on a change in pull request #3071: HBASE-25679 Size of log queue metric is incorrect

shahrs87 commented on a change in pull request #3071:
URL: https://github.com/apache/hbase/pull/3071#discussion_r597950914



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##########
@@ -256,7 +256,6 @@ private void dequeueCurrentLog() throws IOException {
     logQueue.remove(walGroupId);
     setCurrentPath(null);
     setPosition(0);
-    metrics.decrSizeOfLogQueue();

Review comment:
       We already decrement the size of logqueue metric at line#256 on logQueue#remove(walGroupId) so no need to decrement again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org