[GitHub] [nifi] moranr commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…

[GitBox <gi...@apache.org>]

moranr commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#issuecomment-474791853
 
 
   > I think the `Stop & Configure` menu item should be available when the component is stopped but there are active threads. This is most easily testable using `DebugFlow` and setting the `On Trigger Pause Time`. Should this menu item be visible under the same conditions as the `View configuration` menu item?
   
   @mcgilman if I'm understanding correctly, this way you'll only ever see one option (_Configure_ or _View Configuration_ or _Stop & Configure_), right?
   
   Also, if the above is true, we won't need to introduce another icon (fa-pencil-square). The gear icon can be used for all the options.
   
   > Should the status bar be visible when it's unneeded?
   
   You'd have access to bulletin details, so I'd say that is a good reason to keep it.
   
   Other thoughts:
   The icon + button text + background color in the status bar feels like a bit too much. I'm leaning more toward the text only option + subtle underline like in the mockups I put together. Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services