[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…

["tihom88 (via GitHub)" <gi...@apache.org>]

tihom88 commented on code in PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#discussion_r1234751799


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -121,7 +121,7 @@ public void updateIndexDefinitions(NodeBuilder rootBuilder) throws IOException,
 
     protected void dumpIndexDefinitions(NodeStore nodeStore) throws IOException {
         IndexDefinitionPrinter printer = new IndexDefinitionPrinter(nodeStore, indexHelper.getIndexPathService());
-        printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\"]}");
+        printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\", \"-:data\", \"-:suggest-data\"]}");

Review Comment:
   I tested it locally and found out that index definitions don't have :data if --index-paths are provided in command line. But it seems to have :data if --index-paths are not provided.
   For :suggest-data also, found out that :suggest-data node only contained   "lastUpdated" property in case --index-paths are provided. So looks like reindexing works without this info.
   
   As :status-data is something which was part of index-definitions, I added a test case just to check if suggest data is preset with this new filter. Let me know if you think we should add few more test cases/ any specific case you think we should incorporate in current test.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org