[jira] [Closed] (SINGA-152) Worker class needs to take greater responsibility of its setting up

["wangwei (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SINGA-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

wangwei closed SINGA-152.
-------------------------
    Resolution: Unresolved

> Worker class needs to take greater responsibility of its setting up
> -------------------------------------------------------------------
>
>                 Key: SINGA-152
>                 URL: https://issues.apache.org/jira/browse/SINGA-152
>             Project: Singa
>          Issue Type: Improvement
>         Environment: All
>            Reporter: Tan Li Boon
>              Labels: software-engineering
>
> Currently, the Driver class handles the setting up of the Worker objects in Driver::CreateWorkers(). However, much of the work done in that method should really be passed on the the Worker objects instead, likely in the Worker::Setup() method.
> The rationale for this is that it is not really the responsibility of Driver to configure each and every Worker object; rather, it is sufficient to simply pass a job_conf to the Worker and let them set-up themselves.
> A similar logic may be applied to the Server objects.
> Doing so also allows us to easily configure each Worker on a per-Worker basis, simply by adding specifications into the job_conf object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)