You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2023/08/03 08:35:28 UTC
[GitHub] [iotdb] SteveYurongSu opened a new pull request, #10767: [IOTDB-6097] Pipe: Avoid subscrption running with the pattern option causing OOM & Fix de/ser of RecoverProgressIndex
SteveYurongSu opened a new pull request, #10767:
URL: https://github.com/apache/iotdb/pull/10767
This commit fixes 2 issues:
* Subscrption running with the pattern option may cause OOM
How to reproduce:
1. execute sql:
```
create pipe test1
with extractor (
'extractor.history.enable'='false',
'extractor'='iotdb-extractor',
'extractor.realtime.mode'='log',
'extractor.pattern'='root'
)
with connector (
'connector'='iotdb-thrift-connector-v1',
'connector.node-urls'='127.0.0.1:6668'
);
start pipe test1;
```
2. run benchmark: 1 database, 10 devices, 10 measurements.
* java.lang.UnsupportedOperationException: Unsupported PipeRuntimeException type 0 caused by de/ser issue of RecoverProgressIndex
<img width="1194" alt="image" src="https://github.com/apache/iotdb/assets/30497621/d2d35ee7-293b-4594-92f3-fc10b2aa8313">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #10767: [IOTDB-6097] Pipe: Avoid subscrption running with the pattern option causing OOM & Fix de/ser of RecoverProgressIndex
Posted by "coveralls (via GitHub)" <gi...@apache.org>.
coveralls commented on PR #10767:
URL: https://github.com/apache/iotdb/pull/10767#issuecomment-1663624451
[](https://coveralls.io/builds/61758232)
coverage: 48.046% (+0.02%) from 48.025% when pulling **bd24ecb936719d68edd3015588b6091723221532 on fix-pipe-oom-with-pattern** into **e9b9b63a95719c14c674258d92eabf36a0bb69d1 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #10767: [IOTDB-6097] Pipe: Avoid subscrption running with the pattern option causing OOM & Fix de/ser of RecoverProgressIndex
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10767:
URL: https://github.com/apache/iotdb/pull/10767#issuecomment-1663548381
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=10767)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=10767&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=10767&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=10767&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10767&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=10767&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=10767&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=10767&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=10767&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #10767: [IOTDB-6097] Pipe: Avoid subscrption running with the pattern option causing OOM & Fix de/ser of RecoverProgressIndex
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #10767:
URL: https://github.com/apache/iotdb/pull/10767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org