[plc4x] branch feature/mspec-ng updated: fix(plc4j/spi): implement unknown field

[sr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch feature/mspec-ng
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/feature/mspec-ng by this push:
     new d109d44  fix(plc4j/spi): implement unknown field
d109d44 is described below

commit d109d44fabece6e7634d4d7512468379bb9b57d8
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Fri Oct 8 15:32:13 2021 +0200

    fix(plc4j/spi): implement unknown field
---
 .../apache/plc4x/java/spi/codegen/fields/FieldReaderUnknown.java   | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/plc4j/spi/src/main/java/org/apache/plc4x/java/spi/codegen/fields/FieldReaderUnknown.java b/plc4j/spi/src/main/java/org/apache/plc4x/java/spi/codegen/fields/FieldReaderUnknown.java
index 711a203..ed1a081 100644
--- a/plc4j/spi/src/main/java/org/apache/plc4x/java/spi/codegen/fields/FieldReaderUnknown.java
+++ b/plc4j/spi/src/main/java/org/apache/plc4x/java/spi/codegen/fields/FieldReaderUnknown.java
@@ -30,7 +30,12 @@ public class FieldReaderUnknown<T> implements FieldReader<T> {
 
     @Override
     public T readField(String logicalName, DataReader<T> dataReader, WithReaderArgs... readerArgs) throws ParseException {
-        return switchByteOrderIfNecessary(() -> dataReader.read(logicalName, readerArgs), dataReader, extractByteOder(readerArgs).orElse(null));
+        throw new IllegalStateException("not possible with unknown field");
+    }
+
+    public void readUnknownField(String logicalName, DataReader<T> dataReader, WithReaderArgs... readerArgs) throws ParseException {
+        T unknownValue = dataReader.read(logicalName, readerArgs);
+        LOGGER.debug("Read unkown value {}", unknownValue);
     }
 
 }