[GitHub] [hadoop] Kimahriman commented on a change in pull request #3781: YARN-10863: CGroupElasticMemoryController is not work

[GitBox <gi...@apache.org>]

Kimahriman commented on a change in pull request #3781:
URL: https://github.com/apache/hadoop/pull/3781#discussion_r807908358



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
##########
@@ -742,7 +742,8 @@ private void checkLimit(ContainerId containerId, String pId,
                             ProcessTreeInfo ptInfo,
                             long currentVmemUsage,
                             long currentPmemUsage) {
-      if (strictMemoryEnforcement && !elasticMemoryEnforcement) {
+      if ((strictMemoryEnforcement && !elasticMemoryEnforcement) ||
+          (!strictMemoryEnforcement && elasticMemoryEnforcement)) {

Review comment:
       So if the elastic memory control is enabled, it basically disables the CGroup based strict enforcement for some reason, so it has to use the polling mechanism here for that instead. Is that right? I'm trying to find where or why that would be true, but I guess that is what that comment is suggesting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org