[GitHub] [shardingsphere] terrymanu commented on a change in pull request #15452: Update MySQL checksum SQL for scaling

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #15452:
URL: https://github.com/apache/shardingsphere/pull/15452#discussion_r809652894



##########
File path: shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/check/consistency/CRC32MatchMySQLSingleTableDataCalculator.java
##########
@@ -58,17 +58,17 @@ public String getAlgorithmType() {
     public Iterable<Object> calculate(final DataCalculateParameter dataCalculateParameter) {
         String logicTableName = dataCalculateParameter.getLogicTableName();
         List<Long> result = dataCalculateParameter.getColumnNames().stream().map(each -> {
-            String sql = SQL_BUILDER.buildSumCrc32SQL(logicTableName, each);
+            String sql = SQL_BUILDER.buildChecksumSQL(logicTableName, each);

Review comment:
       Why change method name to `check sum`, but class name still `CRC32`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org